Git August 2023

git@phpmyadmin.net

1 participants
51 discussions

[phpmyadmin/phpmyadmin] c0d04b: Add a Response object to ResponseRenderer class

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c0d04b68956b47ce84131b9a68723f58275d789a https://github.com/phpmyadmin/phpmyadmin/commit/c0d04b68956b47ce84131b9a687… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-07 (Mon, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/LicenseController.php M libraries/classes/Controllers/Server/Privileges/AccountLockController.php M libraries/classes/Controllers/Server/Privileges/AccountUnlockController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Server/Variables/GetVariableController.php M libraries/classes/Controllers/Setup/ShowConfigController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/ResponseRenderer.php M libraries/classes/Setup/FormProcessing.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/AbstractControllerTest.php M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php M test/classes/Setup/FormProcessingTest.php M test/classes/Stubs/ResponseRenderer.php M test/classes/UserPreferencesTest.php D test/classes/AbstractNetworkTestCase.php Log Message: ----------- Add a Response object to ResponseRenderer class Uses a Response object to handle the HTTP headers and HTTP status code. This makes the AbstractNetworkTestCase obsolete and removes it. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 5d9932d2cb828ffa9dc0b401d342b48f5ee7d8d0 https://github.com/phpmyadmin/phpmyadmin/commit/5d9932d2cb828ffa9dc0b401d34… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/LicenseController.php M libraries/classes/Controllers/Server/Privileges/AccountLockController.php M libraries/classes/Controllers/Server/Privileges/AccountUnlockController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Server/Variables/GetVariableController.php M libraries/classes/Controllers/Setup/ShowConfigController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/ResponseRenderer.php M libraries/classes/Setup/FormProcessing.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/AbstractControllerTest.php M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php M test/classes/Setup/FormProcessingTest.php M test/classes/Stubs/ResponseRenderer.php M test/classes/UserPreferencesTest.php D test/classes/AbstractNetworkTestCase.php Log Message: ----------- Merge pull request #18609 from MauricioFauth/response-renderer-response Add a Response object to ResponseRenderer class

9 months, 4 weeks

[phpmyadmin/phpmyadmin] a520e2: Move Core::sendHeaderLocation() to ResponseRenderer::redirect()

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a520e235eb78bb2d3d68b3f0d2c7d83f0016d0b6 https://github.com/phpmyadmin/phpmyadmin/commit/a520e235eb78bb2d3d68b3f0d2c… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Config/PageSettings.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/CollationConnectionController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/LogoutController.php M libraries/classes/Controllers/Sql/SqlController.php M libraries/classes/Controllers/ThemeSetController.php M libraries/classes/Core.php M libraries/classes/Export/Export.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Replication/ReplicationGui.php M libraries/classes/ResponseRenderer.php M libraries/classes/UrlRedirector.php M libraries/classes/UserPreferences.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/ConfigTest.php M test/classes/Controllers/CollationConnectionControllerTest.php M test/classes/CoreTest.php M test/classes/UserPreferencesTest.php D templates/header_location.twig Log Message: ----------- Move Core::sendHeaderLocation() to ResponseRenderer::redirect() Removes the IIS specific logic. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 5b428f6f77e80e92ad9d0f286b5bf83f62dd3441 https://github.com/phpmyadmin/phpmyadmin/commit/5b428f6f77e80e92ad9d0f286b5… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Config/PageSettings.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/CollationConnectionController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/LogoutController.php M libraries/classes/Controllers/Sql/SqlController.php M libraries/classes/Controllers/ThemeSetController.php M libraries/classes/Core.php M libraries/classes/Export/Export.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Replication/ReplicationGui.php M libraries/classes/ResponseRenderer.php M libraries/classes/UrlRedirector.php M libraries/classes/UserPreferences.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/ConfigTest.php M test/classes/Controllers/CollationConnectionControllerTest.php M test/classes/CoreTest.php M test/classes/UserPreferencesTest.php D templates/header_location.twig Log Message: ----------- Merge pull request #18603 from MauricioFauth/response-redirect Move Core::sendHeaderLocation() to ResponseRenderer::redirect()

10 months

[phpmyadmin/phpmyadmin] 2c9f28: Reduce initial height of New Routine dialog

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2c9f283fc7b81108486cf2b04c0b09df6a72a3bf https://github.com/phpmyadmin/phpmyadmin/commit/2c9f283fc7b81108486cf2b04c0… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M js/src/database/routines.ts Log Message: ----------- Reduce initial height of New Routine dialog Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] ea971c: Update some JavaScript dependencies

by Maurício Meneghini Fauth

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: ea971c1f814939acc70673ca2491c6061c5e61ee https://github.com/phpmyadmin/phpmyadmin/commit/ea971c1f814939acc70673ca249… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M yarn.lock Log Message: ----------- Update some JavaScript dependencies Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] d3c015: Fail tests with not supported queries

by Maurício Meneghini Fauth

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: d3c01539c7f5215f0b560a5e44fd81629955e74b https://github.com/phpmyadmin/phpmyadmin/commit/d3c01539c7f5215f0b560a5e44f… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M phpunit.xml.dist M test/classes/Controllers/Sql/EnumValuesControllerTest.php M test/classes/Stubs/DbiDummy.php Log Message: ----------- Fail tests with not supported queries Instead of marking them as incomplete. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] f570bf: Pass ServerRequest object to Indexes::doSaveData() method

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f570bf64bf597c271b48eb0bc56504eac8cbf3ec https://github.com/phpmyadmin/phpmyadmin/commit/f570bf64bf597c271b48eb0bc56… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Table/IndexRenameController.php M libraries/classes/Controllers/Table/IndexesController.php M libraries/classes/Table/Indexes.php M phpstan-baseline.neon M test/classes/Table/IndexesTest.php Log Message: ----------- Pass ServerRequest object to Indexes::doSaveData() method This removes the need to call Application::getRequest(). Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] 63e641: Refactor the DbTableExists class

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 63e64107282cc826209124b500c2d3402b1fcd20 https://github.com/phpmyadmin/phpmyadmin/commit/63e64107282cc826209124b500c… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: A test/classes/DbTableExistsTest.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Database/DesignerController.php M libraries/classes/Controllers/Database/EventsController.php M libraries/classes/Controllers/Database/ExportController.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Database/Operations/CollationController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/RoutinesController.php M libraries/classes/Controllers/Database/SearchController.php M libraries/classes/Controllers/Database/SqlController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/Structure/RealRowCountController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/DeleteConfirmController.php M libraries/classes/Controllers/Table/DropColumnConfirmationController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Controllers/Table/IndexRenameController.php M libraries/classes/Controllers/Table/IndexesController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/SqlController.php M libraries/classes/Controllers/Table/Structure/PrimaryController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/TrackingController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Controllers/Triggers/IndexController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Controllers/View/OperationsController.php M libraries/classes/DbTableExists.php M libraries/services.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Database/EventsControllerTest.php M test/classes/Controllers/Database/RoutinesControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ChartControllerTest.php M test/classes/Controllers/Table/DeleteConfirmControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/Controllers/Table/FindReplaceControllerTest.php M test/classes/Controllers/Table/GisVisualizationControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/IndexRenameControllerTest.php M test/classes/Controllers/Table/IndexesControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/Controllers/Table/TrackingControllerTest.php M test/classes/Controllers/Table/ZoomSearchControllerTest.php M test/classes/Controllers/Triggers/IndexControllerTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Refactor the DbTableExists class - Changes static methods to instance methods - Extract response handling to the controllers - Add unit tests for the DbTableExists class - Remove the AbstractController::hasDatabase() method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: e8ebb663ccceae210ba601d0efbe3ffcbf0f44e8 https://github.com/phpmyadmin/phpmyadmin/commit/e8ebb663ccceae210ba601d0efb… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: A test/classes/DbTableExistsTest.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Database/DesignerController.php M libraries/classes/Controllers/Database/EventsController.php M libraries/classes/Controllers/Database/ExportController.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Database/Operations/CollationController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/RoutinesController.php M libraries/classes/Controllers/Database/SearchController.php M libraries/classes/Controllers/Database/SqlController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/Structure/RealRowCountController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/DeleteConfirmController.php M libraries/classes/Controllers/Table/DropColumnConfirmationController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Controllers/Table/IndexRenameController.php M libraries/classes/Controllers/Table/IndexesController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/SqlController.php M libraries/classes/Controllers/Table/Structure/PrimaryController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/TrackingController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Controllers/Triggers/IndexController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Controllers/View/OperationsController.php M libraries/classes/DbTableExists.php M libraries/services.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Database/EventsControllerTest.php M test/classes/Controllers/Database/RoutinesControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ChartControllerTest.php M test/classes/Controllers/Table/DeleteConfirmControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/Controllers/Table/FindReplaceControllerTest.php M test/classes/Controllers/Table/GisVisualizationControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/IndexRenameControllerTest.php M test/classes/Controllers/Table/IndexesControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/Controllers/Table/TrackingControllerTest.php M test/classes/Controllers/Table/ZoomSearchControllerTest.php M test/classes/Controllers/Triggers/IndexControllerTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Merge pull request #18602 from MauricioFauth/db-table-exists-refactor Refactor the DbTableExists class

10 months

[phpmyadmin/phpmyadmin] bfc385: Create Http\Response::write() method to write to the body

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bfc3852e612120627edace7543167f96a3cdf8f5 https://github.com/phpmyadmin/phpmyadmin/commit/bfc3852e612120627edace75431… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-05 (Sat, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Controllers/JavaScriptMessagesController.php M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Http/Response.php M libraries/classes/Routing/Routing.php M test/classes/Http/ResponseTest.php Log Message: ----------- Create Http\Response::write() method to write to the body This method helps when data is written to the body of the response and the response object is returned immediately. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] d89bb2: Replace some 'echo' with ResponseRenderer::addHTML() method

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d89bb277d057062696d77e0032f8b087181db144 https://github.com/phpmyadmin/phpmyadmin/commit/d89bb277d057062696d77e0032f… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/Database/CentralColumnsController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Tracking/Tracking.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Plugins/Auth/AuthenticationCookieTest.php Log Message: ----------- Replace some 'echo' with ResponseRenderer::addHTML() method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

10 months

[phpmyadmin/phpmyadmin] f3b57f: Change export to server file to use redirection after save

by Maurício Meneghini Fauth

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f3b57f6278ff0c1749235938d1eb71fdc6eebba6 https://github.com/phpmyadmin/phpmyadmin/commit/f3b57f6278ff0c1749235938d1e… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export/Export.php M phpstan-baseline.neon M psalm-baseline.xml M templates/export.twig M test/classes/Export/ExportTest.php Log Message: ----------- Change export to server file to use redirection after save Removes the need of calling other controllers. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 234809d47cf39dc05f5344f7ee157686f7ac3871 https://github.com/phpmyadmin/phpmyadmin/commit/234809d47cf39dc05f5344f7ee1… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export/Export.php M phpstan-baseline.neon M psalm-baseline.xml M templates/export.twig M test/classes/Export/ExportTest.php Log Message: ----------- Merge pull request #18599 from MauricioFauth/export-show-page-redirect Change export to server file to use redirection after save

10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Git August 2023