<span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; color: rgb(34, 34, 34); ">Hey, I am back on the track.<div><br></div><div>I have fixed the case problem a while ago but it did not solve the problem completely.</div>
<div><br></div><div>I was wondering maybe it would be possible to enable all error reporting on the <a href="http://demo.phpmyadmin.net/gsoc-blinky" target="_blank" style="color: rgb(53, 66, 88); ">http://demo.phpmyadmin.net/gsoc-blinky</a> so that I can find where the error is.</div>
<div><br></div><div>If this is not possible then an ability for me to tell the demo server to fetch the latest revision from repository would be nice. This would decrease debugging time substantially.</div><div><br></div>
<div>Martynas</div></span><br><div class="gmail_quote">On 23 June 2010 12:08, Herman van Rink <span dir="ltr"><<a href="mailto:rink@initfour.nl">rink@initfour.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Martynas,<br>
<br>
Unfortunately the latest git version is broken for me.<br>
At least in libraries/chart.lib.php on line 5 you use a lower case<br>
filename which does not match in case-sensitive environments.<br>
<br>
Some other points:<br>
* Please use curly braces even in situations where they are technically<br>
optional. Not:<br>
if (is_null($options))<br>
return;<br>
<br>
but<br>
<br>
if (is_null($options)) {<br>
return;<br>
}<br>
<br>
* Please make sure you properly escape variables you print to the user.<br>
$sql_query in tbl_chart.php should probably have htmlspecialchars()<br>
In general ... distrust any data you get from the outside.<br>
<br>
<br>
Most code looks OK though, nice going.<br>
<div><div></div><div class="h5"><br>
--<br>
Met vriendelijke groet / Regards,<br>
<br>
Herman van Rink<br>
Initfour websolutions<br>
<br>
<br>
<br>
------------------------------------------------------------------------------<br>
ThinkGeek and WIRED's GeekDad team up for the Ultimate<br>
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the<br>
lucky parental unit. See the prize list and enter to win:<br>
<a href="http://p.sf.net/sfu/thinkgeek-promo" target="_blank">http://p.sf.net/sfu/thinkgeek-promo</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>