<br><br><div class="gmail_quote">On Sun, Mar 20, 2011 at 5:18 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Le 2011-03-20 07:26, rohit sharma a écrit :<br>
<div><div></div><div class="h5">> On Sun, Mar 20, 2011 at 2:57 PM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> wrote:<br>
><br>
>> Le 2011-03-19 17:26, rohit sharma a écrit :<br>
>>> On Sun, Mar 20, 2011 at 2:36 AM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>><br>
>> wrote:<br>
>>><br>
>>>> Le 2011-03-19 17:03, rohit sharma a écrit :<br>
>>>>> On Sun, Mar 20, 2011 at 2:15 AM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>>> Le 2011-03-19 16:42, rohit sharma a écrit :<br>
>>>>>>> On Sun, Mar 20, 2011 at 2:03 AM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>><br>
>>>>>> wrote:<br>
>>>>>>><br>
>>>>>>>> Le 2011-03-19 16:21, rohit sharma a écrit :<br>
>>>>>>>>> On Sun, Mar 20, 2011 at 1:45 AM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>><br>
>>>>>>>> wrote:<br>
>>>>>>>>><br>
>>>>>>>>>> Hi,<br>
>>>>>>>>>> by default, the ShowSQL directive is true, which makes the<br>
>> generated<br>
>>>>>> SQL<br>
>>>>>>>>>> appear on top for almost every action. This fulfills many needs:<br>
>>>>>>>>>> - people teaching SQL<br>
>>>>>>>>>> - user who wants to verify what phpMyAdmin did in the backend<br>
>>>>>>>>>><br>
>>>>>>>>>> However with Inline edit, we no longer see this generated SQL and<br>
>>>> I'm<br>
>>>>>>>>>> wondering if something should be done about this.<br>
>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>>> Hi,<br>
>>>>>>>>><br>
>>>>>>>>> We can add a field for the last inline_edit query run by the user,<br>
>>>> and<br>
>>>>>>>>> display it using a show/hide button. This field can be added just<br>
>>>>>> beneath<br>
>>>>>>>>> the "generatedSQL" which is always displayed.<br>
>>>>>>>><br>
>>>>>>>> Hi,<br>
>>>>>>>> in the case of Edit, there is no Show/hide because the interface<br>
>>>>>>>> respects the $cfg['ShowSQL'] directive, so why should there be a<br>
>>>>>>>> Show/hide in the case of Inline Edit?<br>
>>>>>>><br>
>>>>>>> Hi,<br>
>>>>>>><br>
>>>>>>> In case of Edit, the query tends to be small, "select * from<br>
>>>> table_name;<br>
>>>>>> "<br>
>>>>>>> (talking generally, although the query can be much longer) , and on<br>
>> the<br>
>>>>>>> other hand inline-edit queries are update queries which can be quite<br>
>>>> long<br>
>>>>>>> for tables with more columns, hence it would take away some valuable<br>
>>>>>> space<br>
>>>>>>> from the displayed table.<br>
>>>>>><br>
>>>>>> I'm not sure I follow you. If you browse a table, click Edit on some<br>
>> row<br>
>>>>>> and make a change, you'll see the generated UPDATE statement, followed<br>
>>>>>> by a SELECT representing your current results set.<br>
>>>>><br>
>>>>> Hi,<br>
>>>>><br>
>>>>> Thanks. I got the idea. But in the case of "inline_edit" the query is<br>
>>>> being<br>
>>>>> sent using Ajax, and the frame won't move after a query execution, so<br>
>>>> where<br>
>>>>> do your propose to display the inline_edit query that was last run, so<br>
>>>> that<br>
>>>>> the user gets notified.<br>
>>>><br>
>>>> At the same place where it's displayed when using the non-Ajax Edit (but<br>
>>>> obviously not with the same mechanism).<br>
>>>><br>
>>>> But my initial question was not about implementation, it was about<br>
>>>> whether we should display UPDATE feedback at all for Inline edit.<br>
>>>><br>
>>>> --<br>
>>>> Marc Delisle<br>
>>>> <a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
>>>><br>
>>><br>
>>> Hi,<br>
>>><br>
>>> After inline_edit, the user instantly gets notified of the change in the<br>
>>> table since the position of the frame remains unchanged. Although it can<br>
>> be<br>
>>> a good idea to display the query for users who wish to know what all<br>
>>> happened in the backend and also, if my query is incorrect, I would like<br>
>> the<br>
>>> error and the query to be displayed for a longer time (permanently)<br>
>> rather<br>
>>> than for some short duration.<br>
>><br>
>> Thanks for your feedback. I believe that the UPDATE query should be<br>
>> displayed, if it works or not, at the same place than when using a<br>
>> traditional edit (if $cfg['ShowSQL'] is true).<br>
>><br>
>>><br>
>>> Also, if my inline_edit query is incorrect, a ajax window displays the<br>
>>> error, but the "back" button on that window takes me all the way to<br>
>> "insert<br>
>>> new record" appending the query in my URL, shouldn't it direct me to the<br>
>>> same page as before ?<br>
>><br>
>> Look on Google for "Ajax back button", you'll see that in general, back<br>
>> button with Ajax is problematic.<br>
>><br>
> Hi,<br>
><br>
> Then the "back" button makes no sense, because the user would like to stay<br>
> on the same page and look at what went wrong, rather than going to any other<br>
> page.<br>
<br></div></div></blockquote><div>Hi,<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div class="h5">
</div></div>I don't understand your point. Why would the user click Back in this<br>
case? He is on the same page and should be able to fix the problem, or<br>
click Hide to quit inline editing.<br></blockquote><div><br>When an error appears in the "inline edit" query, the ajax message displayed is the error message, with a "back" button in the footer. I think the user would click on this button to go back to the page where the table is being displayed, rather he is being sent to some other page. <br>
Here is the error message: <a href="http://web.iiit.ac.in/~rohit.sharmaug08/phpmyadmin/err1.jpeg">http://web.iiit.ac.in/~rohit.sharmaug08/phpmyadmin/err1.jpeg</a><br>and after clicking on "back" the user is sent here: <br>
<a href="http://web.iiit.ac.in/~rohit.sharmaug08/phpmyadmin/err3.jpeg">http://web.iiit.ac.in/~rohit.sharmaug08/phpmyadmin/err3.jpeg</a><br><br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">><br>
><br>
>> I think that we should concentrate on not generating a bad query for<br>
>> inline edit. Do you have a test case where inline edit generates wrong SQL?<br>
><br>
> I think when dealing with foreign keys one can come up with incorrect update<br>
> statements. In that case, the error message being displayed using<br>
> PMA_ajaxShowMessage() isn't helpful enough as it's just transient.<br>
<br>
</div>Would it be better to show it during 10 seconds?<br>
<font color="#888888"><br></font></blockquote><div>In case of an error, it would be better to display the query permanently, so to bring uniformity (either success or failure), the inline_edit query should be displayed permanently like in case of normal query with $cfg['ShowSQL'] set to true.<br>
<br>--<br>Regards<br><br>Rohit Sharma<br>CSE<br><a href="http://iiit.net/">IIIT-Hyderabad</a><br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<font color="#888888">
--<br>
</font><div><div></div><div class="h5">Marc Delisle<br>
<a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
<br>
------------------------------------------------------------------------------<br>
Colocation vs. Managed Hosting<br>
A question and answer guide to determining the best fit<br>
for your organization - today and in the future.<br>
<a href="http://p.sf.net/sfu/internap-sfd2d" target="_blank">http://p.sf.net/sfu/internap-sfd2d</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br><br>