Hi,<br><br>I send my proposal before a while. I've already finished this task: <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=2937379&group_id=23067&atid=377411" target="_blank">http://sourceforge.net/tracker/index.php?func=detail&aid=2937379&group_id=23067&atid=377411</a>, I introduced changes only in one file and one function in phpMyAdmin(<span style="font-size: 11pt; line-height: 115%; font-family: "Calibri","sans-serif";" lang="EN-US">libraries/sqlparser.lib.php </span><span style="font-size: 11pt; line-height: 115%; font-family: "Calibri","sans-serif";" lang="EN-US">PMA_SQP_formatHtml), I </span><span id="result_box" class="short_text" lang="en"><span title="Kliknij, aby wyświetlić alternatywne tłumaczenia" class="hps">publish my git repository with this file on <a href="https://gitorious.org/gandalfml_phpmyadmin/gandalfml_phpmyadmin">https://gitorious.org/gandalfml_phpmyadmin/gandalfml_phpmyadmin</a> and put this link into my proposal, should I put this link into some other places?</span></span><br>
<br>Thank you,<br>Mateusz Lewandowski<br><br><br><div class="gmail_quote">2011/3/27 Dieter Adriaenssens <span dir="ltr"><<a href="mailto:dieter.adriaenssens@gmail.com">dieter.adriaenssens@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Mateusz,<br>
<br>
2011/3/27 Mateusz Lewandowski <<a href="mailto:gandalfml@gmail.com">gandalfml@gmail.com</a>>:<br>
> Hi again,<br>
><br>
<div class="im">> Now I can tell that I understand phpMyAdmin structure of code and generally<br>
> how it works:) The first part of code that I'm going to turn into OOP is<br>
> libraries, there is a horrible disorder in this part, and when you wont use<br>
> some of library function you must make a big effort to do it well. Also<br>
> scripts witch are used to initialised phpMyAdmin should be turn into OOP.<br>
> Next step that I'm going to make is, as I wrote before, to separate out the<br>
> logic of application and the view layer, when this will have been done,<br>
> there will be easy work to port the rest code into OOP. I'll have three<br>
> mounts only for this job, I think that it is possible to turn whole code of<br>
> phpMyAdmin into OOP, maybe I'm wrong, but I'm going to try do it.<br>
<br>
</div>Rewriting all the code of phpMyAdmin into OOP is beyond the scope of<br>
GSoC, for several reasons.<br>
<br>
Firstly, I don't think it can be done, even if you are a very<br>
efficient coder. Take into account that you should not just code<br>
during those 12 weeks, but also, test it and write documentation. Have<br>
you made a week to week plan yet of what you're going to do when?<br>
<br>
Secondly, you won't be the only GSoC student working on phpMyAdmin, so<br>
if you would manage to rewrite everything during those 12 weeks, it<br>
would be impossible to merge either yours or their work with the<br>
current codebase.<br>
<br>
For those reasons, it would be better to focus on a smaller part of<br>
the current code to turn into OOP. Like libraries, or init script,<br>
like you proposed. I'm looking forward to you proposal.<br>
<br>
About MVC, just keep it in mind as a general idea, but don't focus to<br>
much on it. I mean, if it is possible to create a class where you<br>
seperate html (or other output) from the logic, do it. F.e. in a table<br>
class, if there is a function to get all columns, return an array of<br>
columns and not an <ul> or <table> (or something else) list, so that<br>
this function can be used by several parts of phpMyAdmin, even the<br>
ones that don't output html. (Very simple example, I know, but I just<br>
wanted to make clear what I meant)<br>
But rewriting the entire codebase of phpMyAdmin, enforcing a<br>
seperation of View and Logic, is again out of scope for GSoC, for the<br>
same reasons as mentioned above.<br>
<div class="im"><br>
> I have a question in matter of patch that I should sent with my proposal.<br>
> Here<br>
> <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=2937379&group_id=23067&atid=377411" target="_blank">http://sourceforge.net/tracker/index.php?func=detail&aid=2937379&group_id=23067&atid=377411</a><br>
> is written that "Currently SQL pretty printer shows documentation links",<br>
> where are this links? Maybe I overlook something, but can you explain me<br>
> about what exactly is this Feature Request?<br>
<br>
</div>For further info, I propose to ask for it in comment on the feature request.<br>
As for the links : if you execute a query (select, show, insert, ...),<br>
it is shown on top of the screen after execution, showing the result<br>
of the query. f.e. when you look at the contents of a table. In case<br>
of a SELECT statement, the 'SELECT' keyword is a link to the MySQL<br>
documentation.<br>
<div><div></div><div class="h5"><br>
Kind regards,<br>
<br>
Dieter<br>
<br>
> Thank you<br>
> Mateusz Lewandowski<br>
><br>
> 2011/3/26 Mateusz Lewandowski <<a href="mailto:gandalfml@gmail.com">gandalfml@gmail.com</a>><br>
>><br>
>> Hi,<br>
>><br>
>> That's why I wrote that I am not going to implement ORM.<br>
>><br>
>> I already downloaded the phpMyAdmin code from git repository and I started<br>
>> to learn how the phpMyadmin works. I had a look at the reported bugs, I'll<br>
>> try to fix some of them this weekend.<br>
>><br>
>> By the way of MVC, my friend will apply for User interface cleanup and if<br>
>> her proposal turns out to be successful, it will be possible that we can<br>
>> separate out the code into controller and view layers together, so that work<br>
>> will be more effective.<br>
>><br>
>> Thank you<br>
>> Mateusz Lewandowski<br>
>><br>
>> 2011/3/26 Dieter Adriaenssens <<a href="mailto:dieter.adriaenssens@gmail.com">dieter.adriaenssens@gmail.com</a>><br>
>>><br>
>>> Hi Mateusz,<br>
>>><br>
>>> 2011/3/24 Mateusz Lewandowski <<a href="mailto:gandalfml@gmail.com">gandalfml@gmail.com</a>>:<br>
>>> > Hi again,<br>
>>> > Thanks for the answer. I have big experience in design patterns. In my<br>
>>> > PHP<br>
>>> > project I use MCV model. I'll try to implement this model into<br>
>>> > phpMyAdmin,<br>
>>> > but in my opinion there is no point in full implementation of ORM, I'm<br>
>>> > going<br>
>>> > to limit this layer of MVC to minimum or just leave it. Do you think<br>
>>> > that<br>
>>> > this is a good idea?<br>
>>><br>
>>> By ORM, I guess you mean Object-relational mapping? I don't know much<br>
>>> about it, but after a quick glance, I think it would overcomplicate<br>
>>> things.<br>
>>> MVC is OK, the idea is to create classes that can be (re)used in<br>
>>> different parts of phpMyAdmin, anyway, the useroutput (View) should<br>
>>> not be in those general classes. Do you have an idea yet of what part<br>
>>> of phpMyAdmin you would turn into a class?<br>
>>><br>
>>> > I'm not going to look for another job for summer, so that I'll have<br>
>>> > enough<br>
>>> > time for this project, 12 weeks and 40 hours per week are not a<br>
>>> > problem, and<br>
>>> > if needed, I'll be able to make more time for it.<br>
>>><br>
>>> GSoC is a summer job. ;)<br>
>>><br>
>>> > I already looked into application guide. I'll send my proposal on 28th<br>
>>> > March<br>
>>> > as it's written in timeline of GSoC.<br>
>>><br>
>>> Remember to submit a patch by then as well.<br>
>>><br>
>>> Kind regards,<br>
>>><br>
>>> Dieter<br>
>>><br>
>>> > Thank you<br>
>>> > Mateusz Lewandowski<br>
>>> > 2011/3/23 Dieter Adriaenssens <<a href="mailto:dieter.adriaenssens@gmail.com">dieter.adriaenssens@gmail.com</a>><br>
>>> >><br>
>>> >> 2011/3/22 Mateusz Lewandowski <<a href="mailto:gandalfml@gmail.com">gandalfml@gmail.com</a>>:<br>
>>> >> > Hello,<br>
>>> >> ><br>
>>> >> > My name is Mateusz Lewandowski, I'm studying computer science and<br>
>>> >> > I'm on<br>
>>> >> > the<br>
>>> >> > forth term of my studies. I have very strong background in OOP,<br>
>>> >> > especially<br>
>>> >> > in C++ and Java, but I also have some experience in php(I finish one<br>
>>> >> > individual project which is written using Symfony framework an now<br>
>>> >> > is<br>
>>> >> > available on <a href="http://www.biuro-lewandowscy.pl/" target="_blank">http://www.biuro-lewandowscy.pl/</a> ).<br>
>>> >> > I'm very interested in phpMyAdmin OOP project and I'll get familiar<br>
>>> >> > with<br>
>>> >> > code of phpMyAdmin as soon as possible in this week. I think that<br>
>>> >> > porting<br>
>>> >> > existing code into object orientated structure should be easy for<br>
>>> >> > me.<br>
>>> >><br>
>>> >> Hi Mateusz,<br>
>>> >><br>
>>> >> Thanks for your interest in GSoC and in particular the OOP idea.<br>
>>> >><br>
>>> >> It's nice to hear you have some experience with OOP and PHP, do you<br>
>>> >> have experience with Design Patterns? Please take into account we<br>
>>> >> expect you to make a proposal to turn a part of phpMyAdmin code into<br>
>>> >> OOP. Refactoring of the code into a class, implementing it in the rest<br>
>>> >> of the codebase, testing and documenting should be done in about 12<br>
>>> >> weeks of 40 working hours.<br>
>>> >><br>
>>> >> Did you take a look at the application guide [0] yet? We expect you to<br>
>>> >> submit a patch before the end of the application period, to have an<br>
>>> >> idea of your skills and understanding of phpMyAdmin code.<br>
>>> >><br>
>>> >> Good luck with GSoC and with submitting your application.<br>
>>> >><br>
>>> >> Kind regards,<br>
>>> >><br>
>>> >> Dieter Adriaenssens<br>
>>> >><br>
>>> >> [0] <a href="http://wiki.phpmyadmin.net/pma/GSoC_2011_Applicant_Guide" target="_blank">http://wiki.phpmyadmin.net/pma/GSoC_2011_Applicant_Guide</a><br>
>>> >> ><br>
>>> >> > regards,<br>
>>> >> > Mateusz Lewandowski<br>
>>> >> ><br>
>>> >> ><br>
>>> >> ><br>
>>> >> > ------------------------------------------------------------------------------<br>
>>> >> > Enable your software for Intel(R) Active Management Technology to<br>
>>> >> > meet<br>
>>> >> > the<br>
>>> >> > growing manageability and security demands of your customers.<br>
>>> >> > Businesses<br>
>>> >> > are taking advantage of Intel(R) vPro (TM) technology - will your<br>
>>> >> > software<br>
>>> >> > be a part of the solution? Download the Intel(R) Manageability<br>
>>> >> > Checker<br>
>>> >> > today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
>>> >> > _______________________________________________<br>
>>> >> > Phpmyadmin-devel mailing list<br>
>>> >> > <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> >> > <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>>> >> ><br>
>>> >> ><br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> >> --<br>
>>> >> Groetjes,<br>
>>> >><br>
>>> >> Dieter Adriaenssens<br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> >> ------------------------------------------------------------------------------<br>
>>> >> Enable your software for Intel(R) Active Management Technology to meet<br>
>>> >> the<br>
>>> >> growing manageability and security demands of your customers.<br>
>>> >> Businesses<br>
>>> >> are taking advantage of Intel(R) vPro (TM) technology - will your<br>
>>> >> software<br>
>>> >> be a part of the solution? Download the Intel(R) Manageability Checker<br>
>>> >> today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
>>> >> _______________________________________________<br>
>>> >> Phpmyadmin-devel mailing list<br>
>>> >> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> >> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > ------------------------------------------------------------------------------<br>
>>> > Enable your software for Intel(R) Active Management Technology to meet<br>
>>> > the<br>
>>> > growing manageability and security demands of your customers.<br>
>>> > Businesses<br>
>>> > are taking advantage of Intel(R) vPro (TM) technology - will your<br>
>>> > software<br>
>>> > be a part of the solution? Download the Intel(R) Manageability Checker<br>
>>> > today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
>>> > _______________________________________________<br>
>>> > Phpmyadmin-devel mailing list<br>
>>> > <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> > <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>>> ><br>
>>> ><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Groetjes,<br>
>>><br>
>>> Dieter Adriaenssens<br>
>>><br>
>>><br>
>>> ------------------------------------------------------------------------------<br>
>>> Enable your software for Intel(R) Active Management Technology to meet<br>
>>> the<br>
>>> growing manageability and security demands of your customers. Businesses<br>
>>> are taking advantage of Intel(R) vPro (TM) technology - will your<br>
>>> software<br>
>>> be a part of the solution? Download the Intel(R) Manageability Checker<br>
>>> today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
>>> _______________________________________________<br>
>>> Phpmyadmin-devel mailing list<br>
>>> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>><br>
><br>
><br>
> ------------------------------------------------------------------------------<br>
> Enable your software for Intel(R) Active Management Technology to meet the<br>
> growing manageability and security demands of your customers. Businesses<br>
> are taking advantage of Intel(R) vPro (TM) technology - will your software<br>
> be a part of the solution? Download the Intel(R) Manageability Checker<br>
> today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
> _______________________________________________<br>
> Phpmyadmin-devel mailing list<br>
> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
><br>
><br>
<br>
<br>
<br>
--<br>
Groetjes,<br>
<br>
Dieter Adriaenssens<br>
<br>
------------------------------------------------------------------------------<br>
Enable your software for Intel(R) Active Management Technology to meet the<br>
growing manageability and security demands of your customers. Businesses<br>
are taking advantage of Intel(R) vPro (TM) technology - will your software<br>
be a part of the solution? Download the Intel(R) Manageability Checker<br>
today! <a href="http://p.sf.net/sfu/intel-dev2devmar" target="_blank">http://p.sf.net/sfu/intel-dev2devmar</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>