<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div id="yiv1333977603"><div style="color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); font-family: arial,helvetica,sans-serif; font-size: 10pt;"><div id="yiv1333977603yui_3_2_0_3_1304869377443409">Hi,<span><br></span></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">I've fixed the problem below and implement some suggestions. I've just pushed my commits, so the demo server should be updated in about an hour.<br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">On 8 Mei 2011, at 17:49, Marc Delisle <<a rel="nofollow" id="yiv1333977603yui_3_2_0_3_130486937744362" ymailto="mailto:marc@infomarc.info" target="_blank" href="mailto:marc@infomarc.info">marc@infomarc.info</a>> wrote:<br
id="yiv1333977603yui_3_2_0_3_130486937744367"><br id="yiv1333977603yui_3_2_0_3_130486937744370">> Le 2011-05-07 20:53, Aris Feryanto a écrit :<br id="yiv1333977603yui_3_2_0_3_130486937744375">> Hi Aris,<br id="yiv1333977603yui_3_2_0_3_1304869377443220">> <br id="yiv1333977603yui_3_2_0_3_1304869377443225">> On the positive
side, the new feature works well, both with or without<br id="yiv1333977603yui_3_2_0_3_1304869377443230">> pma_recent.<br id="yiv1333977603yui_3_2_0_3_1304869377443235">> <br id="yiv1333977603yui_3_2_0_3_1304869377443240">> On the negative side, I can no longer browse any table (no data is shown<br id="yiv1333977603yui_3_2_0_3_1304869377443245">> and there are warnings at the bottom of the browse page).<br id="yiv1333977603yui_3_2_0_3_1304869377443250">> </div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">This is fixed. I used variable $result, which is used by other part of code. I've changed the variable name to $tmp_result.<br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br id="yiv1333977603yui_3_2_0_3_1304869377443255">> Missing feature:<br id="yiv1333977603yui_3_2_0_3_1304869377443260">> - in /setup I don't see how to define pma_recent<br
id="yiv1333977603yui_3_2_0_3_1304869377443265">> </div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">Added.</div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">> Suggestions:<br id="yiv1333977603yui_3_2_0_3_1304869377443275">> - in saveToDb() you could use REPLACE INTO instead of a SELECT then<br id="yiv1333977603yui_3_2_0_3_1304869377443280">> UPDATE or INSERT, see http://dev.mysql.com/doc/refman/5.1/en/replace.html</div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">Added.</div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br></div><div id="yiv1333977603yui_3_2_0_3_1304869377443409">> <br id="yiv1333977603yui_3_2_0_3_1304869377443290">> - in getHtmlSelect() please use jQuery instead of the onchange event;<br id="yiv1333977603yui_3_2_0_3_1304869377443295">> this is the direction we are taking about js in this project<br><br></div><div
id="yiv1333977603yui_3_2_0_3_1304869377443409">I use onchange event, because the js code need a value generated from php ($GLOBALS['cfg']['LeftDefaultTabTable'], i.e. where the main frame will jump to when a recent table is selected). Should we change this to jQuery? I think that the code will be separated; the jQuery event in .js and the generated value in <script> tag in php.<br><br id="yiv1333977603yui_3_2_0_3_1304869377443300">> <br id="yiv1333977603yui_3_2_0_3_1304869377443305">> - about syntax, please write "if (! isset" instead of "if (!isset" (add<br id="yiv1333977603yui_3_2_0_3_1304869377443310">> a
space after the exclamation point)<br><br>Updated. But, I did a searching and found many parts of existing code use "if (!isset".<br><br id="yiv1333977603yui_3_2_0_3_1304869377443315">> <br id="yiv1333977603yui_3_2_0_3_1304869377443320">> Keep up the good work.<br id="yiv1333977603yui_3_2_0_3_1304869377443325">> <br id="yiv1333977603yui_3_2_0_3_1304869377443330">> -- <br id="yiv1333977603yui_3_2_0_3_1304869377443335">> Marc Delisle<br id="yiv1333977603yui_3_2_0_3_1304869377443340">> http://infomarc.info</div><div id="yiv1333977603yui_3_2_0_3_1304869377443409"><br>--<br>Aris Feryanto<br id="yiv1333977603yui_3_2_0_3_1304869377443406"></div></div></div></div></body></html>