Hi Marc,<br><br><div><div class="gmail_quote"><div>I did following changes and committed to the repository. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Could you change one thing about the js variable names? By convention,<br>
adding a $ prefix is only for jQuery objects. In your code, "$url"<br>
should be "url" because it does not refer to the jQuery object but to an<br>
attribute of it.<br>
<br></blockquote><div><br></div><div>Modified the variable names in navigation.js file.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Also, replace<br>
<script src="js/messages.php"></script><br>
with<br>
<script type="text/javascript" src="js/messages.php"></script><br>
<br></blockquote><div><br></div><div>Modified the navigation.php file. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Another thing: you copied chunks of code from js/functions.js into<br>
js/navigation.js. This means maintainability problems for the future.<br>
<br>
Can you refactor this code into a function which would be in<br>
functions.js and called from both places (table creation in navigation<br>
panel and table creation in main panel)?<br>
<br></blockquote><div><br></div><div>Added the code to PMA_createTableDialog function in function.js file.</div><div> </div><div>Please check the repository. I'll write a blog post on the task by tomorrow. Thank you. </div>
<div><br></div><div>Regards,</div><div>Thilanka. </div></div><br clear="all"><br>-- <br><div><span style="border-collapse:collapse;font-family:arial, sans-serif;font-size:13px"><div style="text-align:left">L G Thilanka Kaushalya <br>
Computer Science & Engineering, <br><div style="color:rgb(80, 0, 80)">University of Moratuwa,<br>Sri Lanka<span></span><br> <br></div></div>Connect with me at,<br> Gmail : <a href="mailto:lgtkaushalya@gmail.com" style="color:rgb(0, 0, 204)" target="_blank">lgtkaushalya@gmail.com</a><br>
Twitter : @thilanka_k<br> Facebook : Thilanka Kaushalya<br> Yahoo : <a href="mailto:lgtkaushalya@yahoo.com" style="color:rgb(0, 0, 204)" target="_blank">lgtkaushalya@yahoo.com</a></span></div>
<div> Blog : <a href="http://coders-view.blogspot.com/" target="_blank">http://coders-view.blogspot.com/</a></div><br><br>
</div>