<br><br><div class="gmail_quote">On Mon, May 23, 2011 at 8:11 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">Ammar Yasir a écrit :<br>
> Hi,<br>
</div><div class="im">> I pushed my work. I just tried to add a sub-tab on the table search<br>
> page, one for the normal search and the other for zoom search. I just<br>
> wanted to get back feedback on whether the design will be okay to proceed?<br>
> Please don't mind how I have coded for now, just coded very quickly to<br>
> get a basic design of the interface. I'll code it properly after<br>
> suggestions.<br>
><br>
> Since user needs to select only two columns in the zoom search page,<br>
> instead of listing out all columns I provided two select boxes where<br>
> user will select the two columns first and I'll display the field type,<br>
> collation, operator and value based on that later. Also since we don't<br>
> need to display the results, the options link on that page was removed.<br>
><br>
> One more thing: For tabs, if I am not providing any link then the mouse<br>
> cursor changes to X and they appear as disabled. How to change that?<br>
><br>
> Regards,<br>
> Ammar Yasir<br>
> <a href="http://repo.or.cz/w/phpmyadmin/ammaryasirr.git" target="_blank">http://repo.or.cz/w/phpmyadmin/ammaryasirr.git</a><br>
<br>
</div>Ammar,<br>
I think that the two-tabbed interface will do the job.<br>
<br>
A few remarks:<br>
<br>
- you have a few undefined variables; in case you are not seeing them,<br>
please use "$cfg['Error_Handler']['display'] = true" in your config.inc.php<br>
<br>
- please merge the original master to your repository, today and<br>
regularly; from<br>
<a href="http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge" target="_blank">http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge</a><br>
<br>
You should also regularly merge back the changes done in official<br>
repository:<br>
<br>
git checkout yourbranch<br>
git remote update origin # assuming official repository is called origin<br>
git merge origin/master<br>
<br>
- in your jQuery you are comparing with "Table Search" and this won't<br>
work with localization<br>
<br>
- in pmahomme theme, labels "Table Search", "Zoom search" are difficult<br>
to read<br>
<br>
- the red X comes from the "error" class so try to find out why your<br>
element has this class<br>
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="h5">Marc Delisle<br>
<a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
<br></div></div></blockquote><div>Hi,<br>I pushed my work. I have added a new file tbl_zoom_select.php which contains the interface. I tried to code everything in tbl_search page but the code becomes very complicated and I had to use a lot of If/else conditions, so i think it will become even more complicated when I'll experiment with plotting libraries. <br>
With a new form its better to switch between the normal table search and zoom search forms without using jQuery. <br>Also, in this form a user can select two same columns but with different search criteria (for example, a film with rating G and a film with rating PG-13) so the query generation for this case cannot be handled in tbl_select.php. It generates a wrong query, so the query generation part of this interface also works a bit differently. It generates two queries, one for each column criteria. I know some code has to be duplicated, but I think its better to develop it as a different component. Otherwise if there are some modifications in the zoom-search part, a lot of changes have to be done in the tbl_select.php page. Its just what I thought, I'll do the interface again if code duplication is an issue.<br>
<br>Regards,<br>Ammar Yasir<br><a href="http://repo.or.cz/w/phpmyadmin/ammaryasirr.git">http://repo.or.cz/w/phpmyadmin/ammaryasirr.git</a><br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div class="h5">
------------------------------------------------------------------------------<br>
What Every C/C++ and Fortran developer Should Know!<br>
Read this article and learn how Intel has extended the reach of its<br>
next-generation tools to help Windows* and Linux* C/C++ and Fortran<br>
developers boost performance applications - including clusters.<br>
<a href="http://p.sf.net/sfu/intel-dev2devmay" target="_blank">http://p.sf.net/sfu/intel-dev2devmay</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>