Hi Marc,<br><br><div><br><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Works fine now. Are you done with this feature? Before I put it in<br>
production, please polish your code in js/server_privileges.js:<br>
<br>
- remove tab characters (we use indents of four spaces)<br>
<br></blockquote><div>I'm using 4 space indentation . I checked the code but I cannot find where have added tab characters. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- use spaces around operators<br>
"url.length-23" should be "url.length - 23"<br>
<br></blockquote><div><br></div><div>Okay I fixed that. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- watch proper code indentations<br>
<br>
- use more spaces around keywords<br>
"if(" should be "if ("<br>
"}else{" should be "} else {"<br>
<br></blockquote><div><br></div><div>Okay I fixed that. </div><div><br></div><div>I fixed the above issues and pushed to the repo. Please check that. </div><div><br></div><div>Regards,</div><div>Thilanka.</div></div><br clear="all">
<br>-- <br><div><span style="border-collapse:collapse;font-family:arial, sans-serif;font-size:13px"><div style="text-align:left">L G Thilanka Kaushalya <br>Computer Science & Engineering, <br><div style="color:rgb(80, 0, 80)">
University of Moratuwa,<br>Sri Lanka<span></span><br> <br></div></div>Connect with me at,<br> Gmail : <a href="mailto:lgtkaushalya@gmail.com" style="color:rgb(0, 0, 204)" target="_blank">lgtkaushalya@gmail.com</a><br>
Twitter : @thilanka_k<br> Facebook : Thilanka Kaushalya<br> Yahoo : <a href="mailto:lgtkaushalya@yahoo.com" style="color:rgb(0, 0, 204)" target="_blank">lgtkaushalya@yahoo.com</a></span></div>
<div> Blog : <a href="http://coders-view.blogspot.com/" target="_blank">http://coders-view.blogspot.com/</a></div><br><br>
</div></div>