
<html><body bgcolor="#FFFFFF"><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); font-size: medium; "><br><span>On 13 Jun 2011, at 20:31, Rouslan Placella <<a href="mailto:rouslan@placella.com" x-apple-data-detectors="true"><a href="mailto:rouslan@placella.com">rouslan@placella.com</a></a>> wrote:</span><br><span></span><br><blockquote type="cite"><span>On Mon, 2011-06-13 at 08:09 -0400, Marc Delisle wrote:</span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>Rouslan Placella a écrit :</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>On Sat, 2011-06-11 at 21:23 -0700, Aris Feryanto wrote:</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Hi Rouslan,</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>----- Original Message -----</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>From: Rouslan Placella <<a href="mailto:rouslan@placella.com" x-apple-data-detectors="true"><a href="mailto:rouslan@placella.com">rouslan@placella.com</a></a>></span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>On Sat, 2011-06-11 at 10:58 +0700, Aris Feryanto wrote:</span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>On 10 Jun 2011, at 20:31, Marc Delisle <<a href="mailto:marc@infomarc.info" x-apple-data-detectors="true"><a href="mailto:marc@infomarc.info">marc@infomarc.info</a></a>> wrote:</span><br></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>I've updated my repo and it should be available in the demo soon. I add</span><br></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>small popup balloon when we hover the column header. I also add some css code to </span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>prettify the column dragging. Please kindly check this.</span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>P.S.: All my changes for column resize and reorder can be found under </span><br></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>"colresize" branch in my git repo.</span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>I found a small bug with the tooltip. See video here:</span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span><a href="http://www.placella.com/pma/colreorder_bug.avi" x-apple-data-detectors="true"><a href="http://www.placella.com/pma/colreorder_bug.avi">http://www.placella.com/pma/colreorder_bug.avi</a></a></span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Thank you for reporting this. It is nice to show that in the video. I tested in some browsers (chrome, firefox, IE) and found that the bug only occurred in firefox/ubuntu. I've fixed this in my git repo.</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>It works great now. By the way, I found another few small issues that</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>you might want to look at :)</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>You hard-coded a lot of sizes in CSS in px units. So now items don't</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>really scale. For example, go to main PMA page and from the dropdown</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>select font size of, for example, 132%. Now go to browse a table and</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>hover the column header. You will see your "Drag to reorder" hint is the</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>same as when the font size was set to 82%, but instead it should be</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>bigger. You can use the 'em' unit instead of the 'px' unit in CSS to fix</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>this.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Also, while resizing a column, the "Drag to reorder" hint keeps trying</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>to pop out when you hover the label of the column. And when you resize</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>the column to a small size, about 10px, and then hold the mouse still a</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>bit both the hints for sorting and reordering pop out (see attached</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>screenshot). And at this point I think that "Sort" alone doesn't mean</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>much any more, so in my opinion the two hints should be merged into one</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>like "Drag to Reorder <br /> Click to Sort".</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Just one hint could be confusing because there are many possibilities:</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>- click on link to sort</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>- click in the <th> (but not on the link) to mark/unmark the column</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>- drag the <th></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Looks like Aris already picked up on my suggestion about the combined</span><br></blockquote><blockquote type="cite"><span>hint. I think it works quite nice in that it only shows "Click to sort"</span><br></blockquote><blockquote type="cite"><span>when you hover the link. I guess that at this point maybe the hint could</span><br></blockquote><blockquote type="cite"><span>contain the same way "Click to mark" when one is over a <th>, but not</span><br></blockquote><blockquote type="cite"><span>the link.</span><br></blockquote><span></span><br><span>Hi,</span><br><span></span><br><span>Just realized my previous email seem not delivered successfully to phpMyAdmin-devel list. I've previously sent an email telling that I will work on merging the tooltip as suggested by Rouslan. I'm still working and testing on this and will add the 'Click to mark'.</span><br><span></span><br><span>I am also fixing the previous code, as it hasn't checked whether we are under Browse tab, before calling the column-order remembering function.</span><br><span></span><br><span>I wonder if there is any existing exact way to check if we are under Browse tab? Current code do the checking using requested url pattern and analyzed SQL query (you may see function PMA_isBrowsing in file libraries/display_tbl.lib.php in my git repo). But, this is not enough for handling load from AJAX request under other tabs (e.g. AJAX request to sql.php caused by pagination of results under SQL tab)</span><br><span></span><br><span></span><br><blockquote type="cite"><span></span></blockquote><span>--</span><br><span>Aris Feryanto</span></span><br></body></html>