<br><br><div class="gmail_quote">On Wed, Jul 6, 2011 at 1:36 AM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Le 2011-07-05 08:50, Ammar Yasir a écrit :<br>
<div class="im">> Hi,<br>
> I had made some changes and pushed my work.<br>
><br>
> * Implemented the Hide/Show search criteria for zoom-search<br>
> interface. After submitting the input criteria the input form<br>
> toggles to hide and can be made visible again by clicking 'Show<br>
> input criteria'<br>
<br>
</div>Good!<br>
<br>
> * The link for 'How to use?' / instructions to use is available<br>
<div class="im">> again by using PMA_ajaxShowMessage<br>
<br>
</div>OK but I don't have the time to read the full message; I must click<br>
again and this is annoying. Maybe leave it in place until I click again?<br>
<br></blockquote><div>Maybe just increase the time to 10 sec? or it may be 10 sec is too long ? <br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
> * Browse/Edit mode it kept so as to disable the data point info form<br>
<div class="im">> elements when using browse mode and enabled when using edit mode.<br>
<br>
</div>I still find the modes confusing. Two other reasons to annoy me:<br>
- now that the search criteria are hidden by default, going into Edit<br>
mode requires more clicks (and maybe I don't even remember that the<br>
modes dialog was there)<br>
<br>
- in browse mode I still see a Submit button<br>
<br>
It would be so much simpler if the interface was always in Edit mode. If<br>
I don't want to edit, I just don't edit.<br>
<div class="im"><br></div></blockquote><div>Ok, I'll remove the feature. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
<br>
> I was thinking that if we had to add more modes like add or delete<br>
> we can add it to this panel.<br>
<br>
</div>We started this dialog with the Search idea, remember. I'm not sure we<br>
want Add and Delete, but should we want these:<br>
- Delete can be implemented with a simple red X or a Delete button in<br>
the current dialog<br>
- Add can be done with another button<br>
<br>
Using "modes" is just not the right way, IMO. The user wants to do<br>
something, so give him the links/buttons to do it; don't ask him to<br>
choose the right mode.<br>
<br>
<br>
> * Changed the names for some configuration directives<br>
<br>
Next time, please do shorter commits, it's easier to see what part of<br>
the code was changed for what reason. I would have preferred 4 commits<br>
for your 4 changes.<br>
<br>
Another thing: why remove this line from config.default.php?<br>
$cfg['ShowDisplayDir'] = false;<br>
<div class="im"><br></div></blockquote><div>Reverted the change. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
><br>
> Now working on to update query generation on edit mode. Also, will check<br>
> out the code snippet for panning tyron suggested.<br>
> I'll look into the default label problem in some time (testing using the<br>
> pma configuration storage).<br>
><br>
> On Sat, Jul 2, 2011 at 4:40 PM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a><br>
</div><div><div></div><div class="h5">> <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>>> wrote:<br>
><br>
> Le 2011-07-01 08:02, Ammar Yasir a écrit :<br>
> > Hi Marc,<br>
> > There are some parts of the interface where we can use ajax. I've<br>
> been<br>
> > working on it, but I'm not much experienced with using ajax so<br>
> not much<br>
> > success. I'll discuss this with thilanka too.<br>
> > Some of parts are:<br>
> > 1) When the plot is generated, we can hide the search criteria.<br>
> This is just<br>
> > like the table search page toggle search criteria but when I use<br>
> the same<br>
> > script as in tbl_select.js it somehow end up losing the plot (it<br>
> generates<br>
> > empty plot).<br>
> > 2) When we click submit after editing the data point values, it<br>
> should<br>
> > generate the sql query and post it to server/post the updated<br>
> values to the<br>
> > server and execute the query there.<br>
> ><br>
> > I think i'll start again fresh with the ajax part.<br>
><br>
> Ammar,<br>
> Firebug's Network panel is very useful to debug Ajax requests and<br>
> replies.<br>
><br>
> --<br>
> Marc Delisle<br>
> <a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
><br>
> ------------------------------------------------------------------------------<br>
> All of the data generated in your IT infrastructure is seriously<br>
> valuable.<br>
> Why? It contains a definitive record of application performance,<br>
> security<br>
> threats, fraudulent activity, and more. Splunk takes this data and makes<br>
> sense of it. IT sense. And common sense.<br>
> <a href="http://p.sf.net/sfu/splunk-d2d-c2" target="_blank">http://p.sf.net/sfu/splunk-d2d-c2</a><br>
> _______________________________________________<br>
> Phpmyadmin-devel mailing list<br>
> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
</div></div>> <mailto:<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a>><br>
<div class="im">> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
><br>
><br>
><br>
><br>
> ------------------------------------------------------------------------------<br>
> All of the data generated in your IT infrastructure is seriously valuable.<br>
> Why? It contains a definitive record of application performance, security<br>
> threats, fraudulent activity, and more. Splunk takes this data and makes<br>
> sense of it. IT sense. And common sense.<br>
> <a href="http://p.sf.net/sfu/splunk-d2d-c2" target="_blank">http://p.sf.net/sfu/splunk-d2d-c2</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Phpmyadmin-devel mailing list<br>
> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
<br>
<br>
</div>--<br>
<div><div></div><div class="h5">Marc Delisle<br>
<a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
<br>
------------------------------------------------------------------------------<br>
All of the data generated in your IT infrastructure is seriously valuable.<br>
Why? It contains a definitive record of application performance, security<br>
threats, fraudulent activity, and more. Splunk takes this data and makes<br>
sense of it. IT sense. And common sense.<br>
<a href="http://p.sf.net/sfu/splunk-d2d-c2" target="_blank">http://p.sf.net/sfu/splunk-d2d-c2</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>