<br><br><div class="gmail_quote">On Thu, Aug 4, 2011 at 5:01 PM, Piotr Przybylski <span dir="ltr"><<a href="mailto:piotr.prz@gmail.com" target="_blank">piotr.prz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2011/8/4 Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>:<br>
<div><div></div><div>> Piotr Przybylski a écrit :<br>
>> 2011/8/4 Ammar Yasir <<a href="mailto:ayax88@gmail.com" target="_blank">ayax88@gmail.com</a>>:<br>
>>><br>
>>> On Thu, Aug 4, 2011 at 2:01 AM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> wrote:<br>
>>>> Ammar Yasir a écrit :<br>
>>>>><br>
>>>>> On Wed, Jul 27, 2011 at 10:22 PM, Ammar Yasir <<a href="mailto:ammaryasir.88@gmail.com" target="_blank">ammaryasir.88@gmail.com</a><br>
>>>>> <mailto:<a href="mailto:ammaryasir.88@gmail.com" target="_blank">ammaryasir.88@gmail.com</a>>> wrote:<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> On Wed, Jul 27, 2011 at 3:37 PM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
>>>>> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>> wrote:<br>
>>>>><br>
>>>>> Ammar,<br>
>>>>> With Firebug I had a look at the network traffic when I click a<br>
>>>>> data<br>
>>>>> point to edit it: I was surprised to see none.<br>
>>>>><br>
>>>>> IMO this is not good: it means that all the columns for all rows<br>
>>>>> are in<br>
>>>>> memory, making the browser able to handle far less rows.<br>
>>>>><br>
>>>>> Is there a reason why you are reading the complete rows to<br>
>>>>> generate the<br>
>>>>> plot? I expected that you would just read the necessary columns,<br>
>>>>> then<br>
>>>>> use AJAX to read a complete row when the user wants to edit it.<br>
>>>>><br>
>>>>> I'm currently working on the edit feature for strings. I'll work on<br>
>>>>> it after this.<br>
>>>>><br>
>>>>> --<br>
>>>>><br>
>>>>> Implemented this and pushed to my repo. I only send the xField, yField<br>
>>>>> and dataLabel to the user now.<br>
>>>> Ammar,<br>
>>>> you have reduced the amount of data transferred between the PHP level<br>
>>>> and the Javascript level, by sending less data in the querydata div.<br>
>>>><br>
>>>> Can you also reduce what is transferred between the MySQL server and the<br>
>>>> web server, by avoiding to generate "SELECT *" in the query generation<br>
>>>> part, instead selecting only the needed columns?<br>
>>>><br>
>>> That would have been the ideal case but to generate the unique-condition(<br>
>>> function PMA_getUniqueCondition($handle, $fields_cnt, $fields_meta, $row,<br>
>>> $force_unique=false) ), I need the complete row. So I cannot do much about<br>
>>> the query generation on the server side other than putting a limit on the<br>
>>> number of rows retrieved.<br>
>>><br>
>><br>
>> It will increase complexity o bit but you can do one of the two:<br>
>> - select one full row with "SELECT * FROM ... LIMIT 1" (any full row<br>
>> will do so no ORDER here) and analyze which rows you need by looking<br>
>> for primary/unique key fields,<br>
>> - if you have only one table you can analyze SHOW CREATE TABLE<br>
>> statement and look for PRIMARY KEY and UNIQUE constraints<br>
><br>
> But PMA_getUniqueCondition() also handles the case when there is no<br>
> unique key.<br>
<br>
</div></div>Yes, but in most cases there is one. If there is no unique key then<br>
'SELECT *' is needed, but if there is one then the built query can<br>
return smaller result, without useless columns.<br>
<br></blockquote><div>I actually had started my implementation like piotr has described but came across the PMA_getUniqueCondition() function later so went ahead with using that. The server side load can be acceptable I guess compared to what I transfer to the Javascript level ?<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
--<br>
<font color="#888888">Piotr Przybylski<br>
</font><div><div></div><div><br>
------------------------------------------------------------------------------<br>
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA<br>
The must-attend event for mobile developers. Connect with experts.<br>
Get tools for creating Super Apps. See the latest technologies.<br>
Sessions, hands-on labs, demos & much more. Register early & save!<br>
<a href="http://p.sf.net/sfu/rim-blackberry-1" target="_blank">http://p.sf.net/sfu/rim-blackberry-1</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>