Hi Marc and Rouslan,<div><br></div><div>Thanks for the quick reply you gave. </div><div><br></div><div>@Marc - I'll refer the feature list and start working with them </div><div>@Rouslan - I'll go through those commits to learn them. Thank you. </div>
<div><br></div><div>Regards,</div><div>Thilanka. <br><br><div class="gmail_quote">On Sat, Dec 17, 2011 at 8:05 PM, Rouslan Placella <span dir="ltr"><<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 17/12/11 13:53, Marc Delisle wrote:<br>
> Le 2011-12-17 01:00, Thilanka Kaushalya a écrit :<br>
>> Hi Marc,<br>
>><br>
>> It was a great gsoc session with PMA last time. I could not contribute it<br>
>> for last few months(after gsoc) because I had my final year exam at<br>
>> university. I'm willing to continue my contribution to phpMyadmin as a non<br>
>> gsoccer. Are there any remaining ideas to continue with ajaxification of<br>
>> the PMA. If so I like to open a discussion on them and continue with them.<br>
>> Thank you.<br>
>><br>
>> Regards,<br>
>> Thilanka.<br>
><br>
> Hi Thilanka,<br>
> some items are listed on [0], please pick one and discuss it on this list.<br>
><br>
> [0] <a href="http://wiki.phpmyadmin.net/pma/AJAXify_Interface" target="_blank">http://wiki.phpmyadmin.net/pma/AJAXify_Interface</a><br>
><br>
<br>
</div>Hi Thilanka,<br>
<br>
off the top of my head I can think of an issue that can be solved with<br>
some ajaxification. On tbl_structure page, if you use the "Add * index"<br>
actions that are available in the "More" dropdown corresponding to a<br>
column in the top table. You will be dropped to sql.php, which will show<br>
the table structure page, but it will not include "tbl_structure.js", so<br>
all the ajax actions on this page will be broken. Of course, if the "Add<br>
* index" links would be ajaxified, this would no longer be a problem,<br>
because we would not leave the tbl_structure page.<br>
<br>
Please do not take the following badly, but rather as constructive<br>
criticism and as a way to learn from your mistakes. I find that some of<br>
the ajaxification work that you did this summer was less then optimal.<br>
As an example, let's look at some issues with the work that you did on<br>
the index editor.<br>
<br>
First of all, you create a custom slider to hide the indexes table. This<br>
was unnecessary, because we already have a PHP function that takes care<br>
of this, which also respects the $cfg['InitialSlidersState']<br>
configuration setting.<br>
<br>
Another issue was that in every ajax reply the top menu was included and<br>
then removed from the reply via jQuery. This, of course, causes transfer<br>
of waste data and it's better not to send it in PHP altogether.<br>
<br>
Then there was an issue when a user requested to add a column to the<br>
index editor: the browser fired an HTTP request of the form to the<br>
server, just to get the same form back with an extra empty field. Of<br>
course, this action can be done on the client side by just cloning a row<br>
from the table.<br>
<br>
So, I fixed all of the above and I also cleaned up the layout of the<br>
editor in order to use less horizontal space and appear more<br>
user-firendly. I invite you to look at these changes so that you can<br>
learn from them. It's commit 863819cbdd759 and the following 10 commits<br>
after that.<br>
<br>
By the way, if you need a mentor or just some guidance, please feel free<br>
to contact me at any time. I would be glad to help you with any issues<br>
you may have and/or review your code.<br>
<br>
Bye,<br>
Rouslan<br>
<div class="HOEnZb"><div class="h5"><br>
------------------------------------------------------------------------------<br>
Learn Windows Azure Live! Tuesday, Dec 13, 2011<br>
Microsoft is holding a special Learn Windows Azure training event for<br>
developers. It will provide a great way to learn Windows Azure and what it<br>
provides. You can attend the event by watching it streamed LIVE online.<br>
Learn more at <a href="http://p.sf.net/sfu/ms-windowsazure" target="_blank">http://p.sf.net/sfu/ms-windowsazure</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px"><div style="text-align:left">L G Thilanka Kaushalya <br>
Computer Science & Engineering, <br><div style="color:rgb(80,0,80)">University of Moratuwa,<br>Sri Lanka<span></span><br> <br></div></div>Connect with me at,<br> Gmail : <a href="mailto:lgtkaushalya@gmail.com" style="color:rgb(0,0,204)" target="_blank">lgtkaushalya@gmail.com</a><br>
Twitter : @thilanka_k<br> Facebook : Thilanka Kaushalya<br> Yahoo : <a href="mailto:lgtkaushalya@yahoo.com" style="color:rgb(0,0,204)" target="_blank">lgtkaushalya@yahoo.com</a></span></div><div>
Blog : <a href="http://coders-view.blogspot.com/" target="_blank">http://coders-view.blogspot.com/</a></div><br><br>
</div>