Hi Rouslan,<div><br></div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Thilanka,<br>
<br>
off the top of my head I can think of an issue that can be solved with<br>
some ajaxification. On tbl_structure page, if you use the "Add * index"<br>
actions that are available in the "More" dropdown corresponding to a<br>
column in the top table. You will be dropped to sql.php, which will show<br>
the table structure page, but it will not include "tbl_structure.js", so<br>
all the ajax actions on this page will be broken. Of course, if the "Add<br>
* index" links would be ajaxified, this would no longer be a problem,<br>
because we would not leave the tbl_structure page.<br>
<br>
Please do not take the following badly, but rather as constructive<br>
criticism and as a way to learn from your mistakes. I find that some of<br>
the ajaxification work that you did this summer was less then optimal.<br>
As an example, let's look at some issues with the work that you did on<br>
the index editor.<br>
<br>
First of all, you create a custom slider to hide the indexes table. This<br>
was unnecessary, because we already have a PHP function that takes care<br>
of this, which also respects the $cfg['InitialSlidersState']<br>
configuration setting.<br>
<br>
Another issue was that in every ajax reply the top menu was included and<br>
then removed from the reply via jQuery. This, of course, causes transfer<br>
of waste data and it's better not to send it in PHP altogether.<br>
<br>
Then there was an issue when a user requested to add a column to the<br>
index editor: the browser fired an HTTP request of the form to the<br>
server, just to get the same form back with an extra empty field. Of<br>
course, this action can be done on the client side by just cloning a row<br>
from the table.<br>
<br>
So, I fixed all of the above and I also cleaned up the layout of the<br>
editor in order to use less horizontal space and appear more<br>
user-firendly. I invite you to look at these changes so that you can<br>
learn from them. It's commit 863819cbdd759 and the following 10 commits<br>
after that.<br>
<br>
By the way, if you need a mentor or just some guidance, please feel free<br>
to contact me at any time. I would be glad to help you with any issues<br>
you may have and/or review your code.<br>
<br>
Bye,<br>
Rouslan<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div><br></div><div>Sorry for the delayed reply I'm sending. I went through your above mentioned commits and observed how was it implemented. Now I realize that some of the previous work I did have optimization problems. I'll go through the list of functionality I have implemented and come up with a optimized solution for them. Thanks for the guidance you gave. </div>
<div><br></div><div>Regards,</div><div>Thilanka. </div></div><div><br></div>-- <br><div><span style="border-collapse:collapse"><div style="text-align:left"><b><font><span style="color:rgb(255,102,0);font-family:arial;font-size:small;letter-spacing:normal">Thilanka Kaushalya,</span><br>
</font></b><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:medium;white-space:nowrap"> </span><b><font><br></font></b></div><font face="arial, sans-serif">Connect with me at,</font><br>
<font face="arial, sans-serif"> Gmail : </font><a href="mailto:lgtkaushalya@gmail.com" style="font-family:arial,sans-serif;font-size:13px;color:rgb(0,0,204)" target="_blank">lgtkaushalya@gmail.com</a><br><font face="arial, sans-serif"> Twitter : @thilanka_k</font><br>
<font face="arial, sans-serif"> Facebook : lgtkaushalya</font><br><font face="arial, sans-serif"> Yahoo : </font><a href="mailto:lgtkaushalya@yahoo.com" style="font-family:arial,sans-serif;font-size:13px;color:rgb(0,0,204)" target="_blank">lgtkaushalya@yahoo.com</a></span></div>
<div> Blog : <a href="http://coders-view.blogspot.com/" target="_blank">http://coders-view.blogspot.com/</a></div><br><br>
</div>