<br><br><div class="gmail_quote">On Sat, Mar 17, 2012 at 9:30 PM, Thilina Buddika Abeyrathna <span dir="ltr"><<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br><br><div class="gmail_quote">On Sat, Mar 17, 2012 at 8:38 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2012-03-17 10:30, Thilina Buddika Abeyrathna a écrit :<br>
<div>> Hi Marc,<br>
> I did a feature request and uploaded the patch file [0] to Sourceforge. But<br>
> it is relevant to Context. Therefor I think it will review after the<br>
> deadline. So I like to much familiar with that Refactoring project.<br>
> When I implementing above feature I went through the tbl_change.php file. I<br>
> need to familiar with other files also which is relevant to above project.<br>
> So if you have any idea, please let me know, I am grateful if I could get<br>
> to know your suggestions.<br>
<br>
</div>Hi Thilina,<br>
I have reviewed your patch.<br>
<br>
About refactoring, I have an idea. In the master branch,<br>
tbl_structure.php, look at lines 199-209. Can you suggest some<br>
refactoring of these lines?<br><font color="#888888"><br></font></blockquote></div></div><div>Hi,</div><div>Thanks Marc. I'll look at that file.</div><div class="HOEnZb"><div><font face="georgia, serif"><br></font></div>
</div></blockquote><div><br>Hi Marc,<br> <br></div><div>Sorry for the delay to reply. I had a mid semester exam. So I look at the tbl_structure.php file and I have some suggestion for refactoring of line 199-209.<br>First thing is it is better to have an underscore for id field<br>
<th id="th<span style="color:rgb(255,0,0)">_</span><?php echo ++$i; ?>"></th><br></div></div><br>Second one is,<br>when using the if condition or for loop with html, it is better to use this style<br>
<br><php? if(condition) : ?><br> <html><br> <html><br><?php endif; ?><br><br>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" size="4">Thilina Buddika Abeyrathna,</font><br>
<font face="georgia, serif">Department of Computer Engineering,</font><br><font face="georgia, serif">Faculty Of Engineering,</font><br><font face="georgia, serif">University of Peradeniya,</font><div><font face="georgia, serif">Sri Lanka.<br>
<br></font></div><br>