<br><br><div class="gmail_quote">On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna <span dir="ltr"><<a href="mailto:pe.chanaka.ck@gmail.com" target="_blank">pe.chanaka.ck@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div><div>On Thu, May 3, 2012 at 4:38 PM, Michal Čihař <span dir="ltr"><<a href="mailto:michal@cihar.com" target="_blank">michal@cihar.com</a>></span> wrote:<br></div></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi<br>
<br>
Dne Tue, 1 May 2012 02:02:38 +0530<br>
Chanaka Dharmarathna <<a href="mailto:pe.chanaka.ck@gmail.com" target="_blank">pe.chanaka.ck@gmail.com</a>> napsal(a):<br>
<div><br>
> I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am<br>
> trying to break the tasks on following areas.<br>
><br>
> * As a library file this should not render the HTML codes in functions it<br>
> selves. First, all the HTML content in functions stored in string and<br>
> render at the bottom of the function.<br>
> Next, return the string having the HTML content, instead of rendering it<br>
> inside the function itself and, from the calling end render that content.<br>
> Probably method names will be modified with adding 'get' phrase.<br>
><br>
> * Some naming conventions are used incorrectly. For method name in lib<br>
> file, naming convention is used generally used as 'PMA_methodName'. But<br>
> some are not following this.<br>
> While correcting them, suggested conventions in my proposal [0] is going to<br>
> applied.<br>
><br>
> * There are several functions having more than 200 lines. I'm intending to<br>
> divide those functions to smaller ones. (PMA_displayTableNavigation(),<br>
> PMA_displayTableHeaders(), PMA_displayTableBody(),<br>
> PMA_displayVerticalTable(), PMA_displayTable())<br>
<br>
</div>I think all this should be rather wrapped in object, so it would be<br>
PMA_Display::someFunction.<br>
<span><font color="#888888"><br>
--<br>
Michal Čihař | <a href="http://cihar.com" target="_blank">http://cihar.com</a> | <a href="http://blog.cihar.com" target="_blank">http://blog.cihar.com</a><br>
</font></span><br></div></div>------------------------------------------------------------------------------<br>
Live Security Virtual Conference<br>
Exclusive live event will cover all the ways today's security and<br>
threat landscape has changed and how IT managers can respond. Discussions<br>
will include endpoint security, mobile security and the latest in malware<br>
threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
<br></blockquote></div><br>Hi Michal,<br><br>Thanks for your reply. I got the point Michal. After the mentioned tasks plus making this as a class, I can use 'PMA_Display::someFunction' where needed.<div>
<div><br clear="all">
<br>Regards !<br>-- <br>____________________________________<br><br>Chanaka Indrajith<br>Bsc.Computer Engineering Undergraduate<br>Faculty of Engineering<br>University of Peradeniya<br>Sri Lanka<br>____________________________________<br>
<br>
</div></div></blockquote></div><br>Hi Michal,<br><br>I am involving with some refactoring in "PMA_displayTableHeaders" function in "display_tbl.lib.php" file.<br>As I mentioned in my previous mail, first I'm trying to render all HTML at the bottom of the function itself.<br>
But I'm facing some problems.<br><br>While current code rendering HTML codes using "echo", there are some function calls which does not return anything but render HTML inside that.<br clear="all">Ex : "PMA_generate_slider_effect" function in common.lib.php file -> call by 739 line in "display_tbl.lib.php" file.<br>
<br>There are several situations like that, in this function. Since they have used in other files also (test cases also implemented for them), I do not think to change those functions.<br><br>What I'm going to do is, remove HTML renderings everywhere inside the function, as well as possible by assigning those HTML to a variable, and render existing content in the variable before calling that kind of function (as above mentioned).<br>
<br>Ex : <br>func {<br> $tableHeadersHTML .= '';<br> ----<br> ---- <br> $tableHeadersHTML .= '<div>'<br> . 'some html content';<br> ----<br> <b>echo $tableHeadersHTML; // render HTML content before another function call which not just return a string of HTML</b><br>
PMA_generate_slider_effect(params);<br> ----<br> // repeat the procedure<br>}<br><br>Before doing this, I would like to hear your suggestions on this.<br><br>Regards !<br>-- <br>____________________________________<br>
<br>Chanaka Indrajith<br>Bsc.Computer Engineering Undergraduate<br>Faculty of Engineering<br>University of Peradeniya<br>Sri Lanka<br>____________________________________<br><br>