<br><br><div class="gmail_quote">On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella <span dir="ltr"><<a href="mailto:rouslan@placella.com" target="_blank">rouslan@placella.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 08/05/12 20:32, Chanaka Dharmarathna wrote:<br>
> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<<br>
> <a href="mailto:pe.chanaka.ck@gmail.com">pe.chanaka.ck@gmail.com</a>> wrote:<br>
><br>
>><br>
>><br>
>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> wrote:<br>
>><br>
>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :<br>
>>><br>
>>>>><br>
>>>>> See "Class Variables and Methods" in [0].<br>
>>>>><br>
>>>>> [0] <a href="http://pear.php.net/manual/en/standards.naming.php" target="_blank">http://pear.php.net/manual/en/standards.naming.php</a><br>
>>><br>
>>>> Hi Marc,<br>
>>>><br>
>>>> I went through that document.<br>
>>>> If the function is global, it will be like 'PMA_getDivForSliderEffect()'<br>
>>>> And if it is a local function (for particular class), it will be like<br>
>>>> 'getDivForSliderEffect()'.<br>
>>><br>
>>> If this is a public method, yes. If a private one, prefix its name with<br>
>>> an underscore.<br>
>>><br>
>>>><br>
>>>> Though I went through that document before this, I couldn't get that<br>
>>> point.<br>
>>>> Thanks for pointing out that.<br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Marc Delisle<br>
>>> <a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
>>><br>
>>><br>
>>><br>
>>> ------------------------------------------------------------------------------<br>
>>> Live Security Virtual Conference<br>
>>> Exclusive live event will cover all the ways today's security and<br>
>>> threat landscape has changed and how IT managers can respond. Discussions<br>
>>> will include endpoint security, mobile security and the latest in malware<br>
>>> threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
>>> _______________________________________________<br>
>>> Phpmyadmin-devel mailing list<br>
>>> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>>><br>
>>><br>
>> Got it Marc.<br>
>> Thanks.<br>
>><br>
>><br>
>> --<br>
>> ____________________________________<br>
>><br>
>> Chanaka Indrajith<br>
>> Bsc.Computer Engineering Undergraduate<br>
>> Faculty of Engineering<br>
>> University of Peradeniya<br>
>> Sri Lanka<br>
>> ____________________________________<br>
>><br>
>><br>
> Hi Michal,<br>
><br>
> I just did my first commit to my repository [0].<br>
> In that commit I have done some refactoring on "PMA_displayTableHeaders()"<br>
> function in "display_tbl.php" file.<br>
> All HTML renderings by "echo"s were removed and those HTML was rendered at<br>
> the bottom of the function at once.<br>
> As well some related functions in "common.lib.php" file also were modified<br>
> in order to return a string of HTML content.<br>
> But the tests were not yet modified according to my modifications.<br>
> Since there was a conflict after my first local commit [1] (git commit), I<br>
> had to resolve conflicts and commit again. (that is [0])<br>
><br>
> I have already installed phpUnit framework.<br>
> It will be very helpful if you can suggest me some documentation to setup<br>
> and run tests in PMA (selenium etc).<br>
><br>
> I'm intending to do the above refactoring procedure to all the functions in<br>
> "display_tbl.lib.php" file before moving to any other task.<br>
><br>
> [0] :<br>
> <a href="https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0" target="_blank">https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0</a><br>
> [1] :<br>
> <a href="https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368" target="_blank">https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368</a><br>
><br>
> Regards !<br>
<br>
</div></div>I had a very quick look at your commit. I think that you're indenting<br>
some lines incorrectly (but I stand to be corrected on this one). AFAIK,<br>
you don't need to line up the operators, just indent by 4 spaces. Example:<br>
<br>
// THIS IS BAD<br>
$radio_html .= '<label for="' . $html_field_id . '">'<br>
. $choice_label<br>
. '</label>';<br>
<br>
// THIS IS GOOD<br>
$radio_html .= '<label for="' . $html_field_id . '">'<br>
. $choice_label<br>
. '</label>';<br>
<br>
// THIS IS ALSO GOOD<br>
$radio_html .= '<label for="' . $html_field_id . '">';<br>
$radio_html .= $choice_label;<br>
$radio_html .= '</label>';<br>
<br>
Bye,<br>
Rouslan<br>
<div class="HOEnZb"><div class="h5"><br>
------------------------------------------------------------------------------<br>
Live Security Virtual Conference<br>
Exclusive live event will cover all the ways today's security and<br>
threat landscape has changed and how IT managers can respond. Discussions<br>
will include endpoint security, mobile security and the latest in malware<br>
threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br>Hi Rouslan,<br><br>Thanks for your suggestion.<br>I'll follow the way you mentioned as "THIS IS GOOD".<br><br clear="all">Regards !<br>-- <br>____________________________________<br>
<br>Chanaka Indrajith<br>Bsc.Computer Engineering Undergraduate<br>Faculty of Engineering<br>University of Peradeniya<br>Sri Lanka<br>____________________________________<br><br>