Hi All,<br><br>While I'm refactoring some files relating to display query results (currently display_tbl.lib.php, common.lib.php), I can method names are used regardless of the inside functionality.<br><br>Ex :- "PMA_displayHtmlRadio" in common.lib.php method return a string of HTML content.<br>
But the name tells the function displays HTML itself.<br>As I feel these things should be modified.<br><br>As library files, they never should render HTML inside the functions themselves.<br>Better thing is to return a string of PHP having the HTML content.<br>
<br>So my suggestion is to use the phrase "get" for the every method which return any data type.<br>So that developer can understand it returns something just looking at the name.<br>Following are some suggested names. (Some of them are already discussed in this mailing list)<br>
<br>Ex: <br>PMA_displayHtmlRadio -> PMA_getRadioFields<br>PMA_generateSliderEffect -> PMA_getDivForSliderEffect<br>PMA_generateHtmlDropdown -> PMA_getDropdown<br>PMA_displayTableNavigationButton -> getTableNavigationButton<br clear="all">
(All above functions return strings)<br><br>Hope to join a discussion on this.<br><br>Regards !<br>-- <br>____________________________________<br><br>Chanaka Indrajith<br>Bsc.Computer Engineering Undergraduate<br>Faculty of Engineering<br>
University of Peradeniya<br>Sri Lanka<br>____________________________________<br><br>