<br><br><div class="gmail_quote">On Mon, May 21, 2012 at 9:54 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2012-05-21 11:50, Thilina Buddika Abeyrathna a écrit :<br>
<div class="im">> On Mon, May 21, 2012 at 9:17 PM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> wrote:<br>
><br>
>> Le 2012-05-21 11:41, Thilina Buddika Abeyrathna a écrit :<br>
>>> Hi Marc,<br>
>>> In tbl_replace.php I don't see any usage of $me_fields variable. So I'm<br>
>>> going to remove the declaration and I'll change the all variable names<br>
>>> $me_* to $multi_edit_*.<br>
>>> Is it OK?<br>
>><br>
>> Hi Thilina,<br>
>> If you have access to command-line git, try this:<br>
>><br>
>> git grep '$me_fields'<br>
>><br>
>> and you'll see that libraries/tbl_replace_fields.inc.php is using these<br>
>> variables (other scripts are also using them).<br>
>><br>
>> I just realize that Marc. Sorry for the mistake.<br>
> And is it ok to changing variable name like above.<br>
<br>
</div>Yes, this is good refactoring. Of course, you know I'm allergic to using<br>
the term "field" when it refers to a table's column.</blockquote><div><br></div><div>Ok Marc. :) </div></div>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" size="4">Thilina Buddika Abeyrathna,</font><br>
<font face="georgia, serif">Department of Computer Engineering,</font><br><font face="georgia, serif">Faculty Of Engineering,</font><br><font face="georgia, serif">University of Peradeniya,</font><div><font face="georgia, serif">Sri Lanka.<br>
<br></font></div><br>