<br><br><div class="gmail_quote">On Wed, May 30, 2012 at 1:53 AM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2012-05-29 15:34, Atul Pratap Singh a écrit :<br>
<div><div>> On Tue, May 29, 2012 at 10:04 PM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> wrote:<br>
><br>
>> Le 2012-05-29 10:46, Atul Pratap Singh a écrit :<br>
>>> Hi Marc,<br>
>>> While looking at "tbl_zoom_select.php":-<br>
>>><br>
>>> Line 191-201<br>
>>> if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] !=<br>
>>> 'pma_null')) {<br>
>>> $flag = 2;<br>
>>> for ($i = 0 ; $i < 4 ; $i++) {<br>
>>> if ($inputs[$i] != 'pma_null') {<br>
>>> $key = array_search($inputs[$i], $fields_list);<br>
>>> $tbl_fields_type[$i] = $fields_type[$key];<br>
>>> $tbl_fields_collation[$i] = $fields_collation[$key];<br>
>>> $tbl_fields_null[$i] = $fields_null[$key];<br>
>>> }<br>
>>> }<br>
>>> }<br>
>>><br>
>>> As the condition would be true in cases when post param $inputs is set<br>
>> and<br>
>>> has index 0 or 1 set to some column name. It would mostly happen if a<br>
>> half<br>
>>> or full filled search form is submitted, but there seems to be no further<br>
>>> use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type<br>
>>> gets used afterwards with indexes >= 4.<br>
>><br>
>> Atul,<br>
>> Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.<br>
>><br>
>><br>
>>> I think as a result after the zoom plot is displayed, clicking at "show<br>
>>> search criteria" doesn't show any previously filled criteria.<br>
>><br>
>> Well, I see the chosen two column names, but indeed there seems to be a<br>
>> bug because at least the operator and value should be displayed.<br>
>><br>
> Ok Marc, I'll remove the bug and also any unused variables.<br>
<br>
</div></div>The bug was introduced by<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/commit/9be5d8e02ae431be040e655da0eb39b134cd107d" target="_blank">https://github.com/phpmyadmin/phpmyadmin/commit/9be5d8e02ae431be040e655da0eb39b134cd107d</a>.<br>
<br>
Beware that js/tbl_zoom_plot.js has been renamed to<br>
js/tbl_zoom_plot_jqplot.js when I made the changes from Highcharts to<br>
jqplot.<br>
<div><div><br></div></div></blockquote><div>Thanks Marc,</div><div>I have tried to fix the bug for now. Please check [0]. </div><div><br></div><div>Also, I have noticed that in case of updating the field information using AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box.</div>
<div>1. Open zoom search for a table with at least a field of timestamp type</div><div>2. Select the timestamp type column from dropdown.</div><div>3. Notice simply an input box without datepicker.</div>
<div><br></div><div>[0] <a href="https://github.com/zixtor/phpmyadmin/commit/b37066c4a4cf9b19ee98742837b01fb21d89abb4" target="_blank">https://github.com/zixtor/phpmyadmin/commit/b37066c4a4cf9b19ee98742837b01fb21d89abb4</a> </div>
<div><br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
><br>
>><br>
>>> I also didn't understand the use of $flag variable.<br>
>><br>
>> This must have been some debugging info, you can safely remove it.<br>
>><br>
>>><br>
>>> Thanks<br>
>>><br>
>>><br>
>>><br>
>>><br>
>> ------------------------------------------------------------------------------<br>
>>> Live Security Virtual Conference<br>
>>> Exclusive live event will cover all the ways today's security and<br>
>>> threat landscape has changed and how IT managers can respond. Discussions<br>
>>> will include endpoint security, mobile security and the latest in malware<br>
>>> threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> Phpmyadmin-devel mailing list<br>
>>> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>>> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>><br>
>><br>
>> --<br>
>> Marc Delisle<br>
>> <a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
>><br>
>><br>
>><br>
>> ------------------------------------------------------------------------------<br>
>> Live Security Virtual Conference<br>
>> Exclusive live event will cover all the ways today's security and<br>
>> threat landscape has changed and how IT managers can respond. Discussions<br>
>> will include endpoint security, mobile security and the latest in malware<br>
>> threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
>> _______________________________________________<br>
>> Phpmyadmin-devel mailing list<br>
>> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
>> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
>><br>
>><br>
><br>
><br>
><br>
><br>
> ------------------------------------------------------------------------------<br>
> Live Security Virtual Conference<br>
> Exclusive live event will cover all the ways today's security and<br>
> threat landscape has changed and how IT managers can respond. Discussions<br>
> will include endpoint security, mobile security and the latest in malware<br>
> threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Phpmyadmin-devel mailing list<br>
> <a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
> <a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
<br>
<br>
--<br>
Marc Delisle<br>
<a href="http://infomarc.info" target="_blank">http://infomarc.info</a><br>
<br>
</div></div><br>------------------------------------------------------------------------------<br>
Live Security Virtual Conference<br>
Exclusive live event will cover all the ways today's security and<br>
threat landscape has changed and how IT managers can respond. Discussions<br>
will include endpoint security, mobile security and the latest in malware<br>
threats. <a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net" target="_blank">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Atul Pratap Singh<div>Senior Undergraduate Student</div><div>Institute Of Technology,<br>Banaras Hindu University, Varanasi,<br>India.</div><br>