<br><br><div class="gmail_quote">On Thu, Jun 28, 2012 at 5:18 AM, Thilina Buddika Abeyrathna <span dir="ltr"><<a href="mailto:thilinaabeyrathna@gmail.com" target="_blank">thilinaabeyrathna@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote"><div class="im">On Wed, Jun 27, 2012 at 5:43 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2012-06-26 13:16, Thilina Buddika Abeyrathna a écrit :<br>
<div>> On Sun, Jun 24, 2012 at 4:38 AM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> wrote:<br>
><br>
>> Hi Thilina,<br>
>> I prefer that you fix bugs in your previous refactoring before starting<br>
>> a new sub-project (you have started work on server_privileges.php)<br>
>><br>
>> Please compile a list of these bugs, open artefacts on our bug tracker<br>
>> and reply here references to these bugs, in one post. I will then verify<br>
>> to ensure we did not miss anything.<br>
>><br>
>><br>
> [1] -<br>
> <a href="https://sourceforge.net/tracker/?func=detail&aid=3538189&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538189&group_id=23067&atid=377408</a><br>
<br>
</div>Thilina,<br>
please create artifacts in the bug tracker for these other problems:<br>
<br>
1. "Edit next row" choice is no longer offered in the actions panel<br>
<br>
2. "Insert another new row" produces<br>
Fatal error: Call to undefined function PMA_showMessage() in<br>
/opt/pma-git/phpmyadmin/tbl_change.php on line 129<br>
<br>
3. A logic error remains about setting $timestamp_seen to true, see [0];<br>
therefore, behavior is different than version 3.5 when inserting in a<br>
table that has more than one timestamp.<br>
<br>
[0] <a href="https://github.com/thilinaa/phpmyadmin/commit/798ccce1" target="_blank">https://github.com/thilinaa/phpmyadmin/commit/798ccce1</a><br>
<div><div><br></div></div></blockquote></div><div>Ok Marc.</div><div>[0] - <a href="https://sourceforge.net/tracker/?func=detail&aid=3538530&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538530&group_id=23067&atid=377408</a></div>
</div><div> [1] - <a href="https://sourceforge.net/tracker/?func=detail&aid=3538527&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538527&group_id=23067&atid=377408</a></div>
<div>[2] - <a href="https://sourceforge.net/tracker/?func=detail&aid=3538524&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538524&group_id=23067&atid=377408</a></div>
<div class="HOEnZb"><div class="h5">
<div><br></div></div></div></blockquote><div><br></div><div>[1] - fixed in [3] commit.</div><div>[3] - <a href="https://github.com/thilinaa/phpmyadmin/commit/e953deca3c50ee424d7597ce890a8a2641c05ed8">https://github.com/thilinaa/phpmyadmin/commit/e953deca3c50ee424d7597ce890a8a2641c05ed8</a> </div>
</div><div><br></div>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" color="#660000">Thilina Abeyrathna</font><font face="georgia, serif"><br></font><div><font face="georgia, serif" size="1">Gtalk : thilinaabeyrathna</font></div>
<div><font face="georgia, serif" size="1">skype: thilinabuddika88</font></div><div><font face="georgia, serif"><font size="1"><a href="http://thilinaa.wordpress.com" target="_blank">thilinaa.wordpress.com</a> <br></font><br>
</font></div><br>