<br><br><div class="gmail_quote">On Sat, Jun 30, 2012 at 5:53 PM, Thilina Buddika Abeyrathna <span dir="ltr"><<a href="mailto:thilinaabeyrathna@gmail.com" target="_blank">thilinaabeyrathna@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote"><div><div class="h5">On Sat, Jun 30, 2012 at 5:26 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2012-06-30 04:45, Thilina Buddika Abeyrathna a écrit :<br>
> On Thu, Jun 28, 2012 at 5:18 AM, Thilina Buddika Abeyrathna <<br>
> <a href="mailto:thilinaabeyrathna@gmail.com" target="_blank">thilinaabeyrathna@gmail.com</a>> wrote:<br>
><br>
>><br>
>><br>
>> On Wed, Jun 27, 2012 at 5:43 PM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> wrote:<br>
>><br>
>>> Le 2012-06-26 13:16, Thilina Buddika Abeyrathna a écrit :<br>
>>>> On Sun, Jun 24, 2012 at 4:38 AM, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>><br>
>>> wrote:<br>
>>>><br>
>>>>> Hi Thilina,<br>
>>>>> I prefer that you fix bugs in your previous refactoring before starting<br>
>>>>> a new sub-project (you have started work on server_privileges.php)<br>
>>>>><br>
>>>>> Please compile a list of these bugs, open artefacts on our bug tracker<br>
>>>>> and reply here references to these bugs, in one post. I will then<br>
>>> verify<br>
>>>>> to ensure we did not miss anything.<br>
>>>>><br>
>>>>><br>
>>>> [1] -<br>
>>>><br>
>>> <a href="https://sourceforge.net/tracker/?func=detail&aid=3538189&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538189&group_id=23067&atid=377408</a><br>
>>><br>
>>> Thilina,<br>
>>> please create artifacts in the bug tracker for these other problems:<br>
>>><br>
>>> 1. "Edit next row" choice is no longer offered in the actions panel<br>
>>><br>
>>> 2. "Insert another new row" produces<br>
>>> Fatal error: Call to undefined function PMA_showMessage() in<br>
>>> /opt/pma-git/phpmyadmin/tbl_change.php on line 129<br>
>>><br>
>>> C. A logic error remains about setting $timestamp_seen to true, see [0];<br>
>>> therefore, behavior is different than version 3.5 when inserting in a<br>
>>> table that has more than one timestamp.<br>
>>><br>
>>> [0] <a href="https://github.com/thilinaa/phpmyadmin/commit/798ccce1" target="_blank">https://github.com/thilinaa/phpmyadmin/commit/798ccce1</a><br>
>>><br>
>>> Ok Marc.<br>
>> [0] -<br>
>> <a href="https://sourceforge.net/tracker/?func=detail&aid=3538530&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538530&group_id=23067&atid=377408</a><br>
>> [1] -<br>
>> <a href="https://sourceforge.net/tracker/?func=detail&aid=3538527&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538527&group_id=23067&atid=377408</a><br>
>> [2] -<br>
>> <a href="https://sourceforge.net/tracker/?func=detail&aid=3538524&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3538524&group_id=23067&atid=377408</a><br>
>><br>
>><br>
> [1] - fixed in [3] commit.<br>
> [3] -<br>
> <a href="https://github.com/thilinaa/phpmyadmin/commit/e953deca3c50ee424d7597ce890a8a2641c05ed8" target="_blank">https://github.com/thilinaa/phpmyadmin/commit/e953deca3c50ee424d7597ce890a8a2641c05ed8</a><br>
<br>
This one was not completely fixed, as the message containing the INSERT<br>
statement was not displayed. I fixed it with [4].<br>
<br></blockquote></div></div><div>Thanks marc.</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I found another bug: After a simple INSERT (insert as new row and then<br>
go back to previous page), the generated INSERT statement is not<br>
displayed. see [5].<br>
<br>
[4]<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/commit/a83f42eaa6619b8351ff67bbe528098415d53644" target="_blank">https://github.com/phpmyadmin/phpmyadmin/commit/a83f42eaa6619b8351ff67bbe528098415d53644</a><br>
<br>
[5]<br>
<a href="https://sourceforge.net/tracker/?func=detail&aid=3539142&group_id=23067&atid=377408" target="_blank">https://sourceforge.net/tracker/?func=detail&aid=3539142&group_id=23067&atid=377408</a></blockquote>
<div><br></div></div><div>I'll look Marc. </div></div></blockquote><div><br></div><div>Hi Marc. I did the 'git bisect' to figure out when brokenness introduced. But according to that it happen not because of my changes. Last good commit is [0]</div>
<div>bad commit [1] - this was an upstream merge</div><div><font color="#333333" face="Consolas, Menlo, Liberation Mono, Courier, monospace"><span style="font-size:14px"><br></span></font></div><div><font color="#333333" face="Consolas, Menlo, Liberation Mono, Courier, monospace"><span style="font-size:14px">[0] - </span></font><a href="https://github.com/thilinaa/phpmyadmin/commit/11776f7f116d42f5c7a7d62f7321b879e16601f3">https://github.com/thilinaa/phpmyadmin/commit/11776f7f116d42f5c7a7d62f7321b879e16601f3</a></div>
<div><span style="background-color:rgb(255,255,255);color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:16px"> [1] - </span><a href="https://github.com/thilinaa/phpmyadmin/commit/f9999253132094226fe0f30aa886a76a176b7cd6">https://github.com/thilinaa/phpmyadmin/commit/f9999253132094226fe0f30aa886a76a176b7cd6</a></div>
</div><div><br></div>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" color="#660000">Thilina Abeyrathna</font><font face="georgia, serif"><br></font><div><font face="georgia, serif" size="1">Gtalk : thilinaabeyrathna</font></div>
<div><font face="georgia, serif" size="1">skype: thilinabuddika88</font></div><div><font face="georgia, serif"><font size="1"><a href="http://thilinaa.wordpress.com" target="_blank">thilinaa.wordpress.com</a> <br></font><br>
</font></div><br>