<br><br><div class="gmail_quote">On Sat, Aug 4, 2012 at 3:00 PM, Rouslan Placella <span dir="ltr"><<a href="mailto:rouslan@placella.com" target="_blank">rouslan@placella.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 04/08/2012 01:39, Thilina Buddika Abeyrathna wrote:<br>
><br>
><br>
> On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <<a href="mailto:rouslan@placella.com">rouslan@placella.com</a><br>
</div><div class="im">> <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>>> wrote:<br>
><br>
> On 03/08/2012 17:45, Rouslan Placella wrote:<br>
> > On 03/08/2012 17:43, Marc Delisle wrote:<br>
> >> Marc Delisle a écrit :<br>
> >>> Rouslan Placella a écrit :<br>
> >>>> On 03/08/2012 14:19, Marc Delisle wrote:<br>
> >>>>> Michal Čihař a écrit :<br>
> >>>>>> Hi<br>
> >>>>>><br>
> >>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200<br>
> >>>>>> Rouslan Placella <<a href="mailto:rouslan@placella.com">rouslan@placella.com</a><br>
</div>> <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>>> napsal(a):<br>
<div><div class="h5">> >>>>>><br>
> >>>>>>> Quick question: why do we have two forms for renaming a<br>
> table on<br>
> >>>>>>> tbl_operations.php? Can one be dropped? Please see attached<br>
> screenshot<br>
> >>>>>>> for the location of forms.<br>
> >>>> Well, I have a dilemma about this form in my branch. With the<br>
> "rename"<br>
> >>>> functionality in the table options form, a dedicated ajax<br>
> handler is<br>
> >>>> necessary for it to work. Without, the form can be handled by<br>
> a generic<br>
> >>>> page loading mechanism, which means less code and a more<br>
> maintainable<br>
> >>>> solution.<br>
> >>>><br>
> >>>>>> The difference is probably in implementation - in same<br>
> database, you<br>
> >>>>>> can use just RENAME, for moving data to other database, this<br>
> might<br>
> >>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT.<br>
> >>>> I see, it sounds a bit more complicated than I was hoping for.<br>
> >>>><br>
> >>>>>> Still it would be better to merge these and use RENAME when<br>
> possible<br>
> >>>>>> and fallback to complex method if needed.<br>
> >>>>> I'm not sure these should be merged. In the mind of some<br>
> users, renaming<br>
> >>>>> and moving are different actions.<br>
> >>>> Then we could call it "rename/move"...<br>
> >>><br>
> >>> I would be happy with that. It would have the added benefit of<br>
> removing<br>
> >>> the rename table dialog from the table options fieldset, where<br>
> it does<br>
> >>> not really belong.<br>
> >>><br>
> >> By the way, Thilina is refactoring db and tbl operations these<br>
> days...<br>
> ><br>
> > Sounds like one of us will have a few conflicts to resolve. I already<br>
> > have some committed changes in those areas. When does he expect to<br>
> > finish up with that?<br>
><br>
> Or did you mean asking Thilina to look into this?<br>
><br>
> Hi,<br>
> For the moment, I have done some refactoring for both rename table and<br>
> move table operations in my tree,<br>
<br>
</div></div>Which repo/branch/commits? I don't see anything like that in<br>
<a href="https://github.com/thilinaa/phpmyadmin/commits/master" target="_blank">https://github.com/thilinaa/phpmyadmin/commits/master</a><br>
<br></blockquote><div>Some commits, </div><div>[1] - <a href="https://github.com/thilinaa/phpmyadmin/commit/d9933223977c52426edcfc9f558fc754baa6217b">https://github.com/thilinaa/phpmyadmin/commit/d9933223977c52426edcfc9f558fc754baa6217b</a></div>
<div>[2] - <a href="https://github.com/thilinaa/phpmyadmin/commit/83401195710de736dc6217f885313b5dad9071ae">https://github.com/thilinaa/phpmyadmin/commit/83401195710de736dc6217f885313b5dad9071ae</a></div><div><br></div><div>
But some functions has changed for further refactoring.</div><div> </div></div><div><br></div>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" color="#660000">Thilina Abeyrathna</font><font face="georgia, serif"><br>
</font><div><font face="georgia, serif" size="1">Gtalk : thilinaabeyrathna</font></div><div><font face="georgia, serif" size="1">skype: thilinabuddika88</font></div><div><font face="georgia, serif"><font size="1"><a href="http://thilinaa.wordpress.com" target="_blank">thilinaa.wordpress.com</a> <br>
</font><br></font></div><br>