<br><br><div class="gmail_quote">On Sat, Aug 18, 2012 at 12:50 AM, Rouslan Placella <span dir="ltr"><<a href="mailto:rouslan@placella.com" target="_blank">rouslan@placella.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 16/08/2012 21:56, Thilina Buddika Abeyrathna wrote:<br>
><br>
><br>
> On Fri, Aug 17, 2012 at 1:16 AM, Rouslan Placella <<a href="mailto:rouslan@placella.com">rouslan@placella.com</a><br>
</div><div class="im">> <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>>> wrote:<br>
><br>
> On 16/08/2012 17:06, Thilina Buddika Abeyrathna wrote:<br>
> ><br>
> ><br>
> > On Thu, Aug 16, 2012 at 2:57 AM, Thilina Buddika Abeyrathna<br>
> > <<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a> <mailto:<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a>><br>
</div>> <mailto:<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a><br>
<div class="im">> <mailto:<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a>>>> wrote:<br>
> ><br>
> ><br>
> ><br>
> > On Thu, Aug 16, 2012 at 2:55 AM, Marc Delisle<br>
> <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>><br>
</div><div class="im">> > <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>>>> wrote:<br>
> ><br>
> > Le 2012-08-15 16:24, Thilina Buddika Abeyrathna a écrit :<br>
> > > Hi Marc,<br>
> > > I'm looking [1] bug in the table operation page,<br>
> > > I 'git checkout' to very old commit and check the same<br>
> bug in<br>
> > there, But<br>
> > > still this bug was there,<br>
> > > I found that, first bad commit was<br>
> > 4d2fcd910bc7e07114fcc76f55705c1a6e8c685e<br>
> > > (This is not a my commit)<br>
> > > I can't figure out where is this error happen.<br>
> > ><br>
> > > [1] -<br>
> > ><br>
> ><br>
> <a href="http://sourceforge.net/tracker/?func=detail&aid=3555235&group_id=23067&atid=377408" target="_blank">http://sourceforge.net/tracker/?func=detail&aid=3555235&group_id=23067&atid=377408</a><br>
> ><br>
> > Thilina,<br>
> > please use "git bisect" [2] to find the problematic<br>
> commits. I used<br>
> ><br>
> > git bisect start HEAD QA_3_5<br>
> ><br>
> > and found this:<br>
> ><br>
> > a16e723048940f87b4be4b4097d16c4376826f2c is the first bad<br>
> commit<br>
> > commit a16e723048940f87b4be4b4097d16c4376826f2c<br>
> > Author: Rouslan Placella <<a href="mailto:rouslan@placella.com">rouslan@placella.com</a><br>
> <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>><br>
</div>> > <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a> <mailto:<a href="mailto:rouslan@placella.com">rouslan@placella.com</a>>>><br>
<div class="im">> > Date: Mon Jun 11 17:58:35 2012 +0100<br>
> ><br>
> > Dropped PMA_ajaxResponse()<br>
> ><br>
> > [2]<br>
> <a href="http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit" target="_blank">http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit</a><br>
> ><br>
> ><br>
> > Thank you Marc.<br>
> ><br>
> > Hi Rouslan,<br>
> > Can you look at this error?<br>
><br>
> Problem #1 is already fixed in my branch [0], so I guess that you can<br>
> ignore it.<br>
><br>
> Problem #2 has nothing to do with my code. Also keep in mind that the<br>
> issue comes up when changing from innodb to myisam, but not the other<br>
> way around. Here's the results of a bisect:<br>
><br>
> 83401195710de736dc6217f885313b5dad9071ae is the first bad commit<br>
> commit 83401195710de736dc6217f885313b5dad9071ae<br>
> Author: Thilina Buddika <<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a><br>
</div>> <mailto:<a href="mailto:thilinaabeyrathna@gmail.com">thilinaabeyrathna@gmail.com</a>>><br>
<div class="im">> Date: Wed Aug 1 13:52:49 2012 +0530<br>
><br>
> further refactoring for PMA_getTableOptionFieldset()<br>
><br>
> :040000 040000 f7dba249f1ec47de37b26a2df7fc4562dd717b80<br>
> 7b7945eceffca79186916f9ed7e4e30f0d4cb0d7 M libraries<br>
><br>
> Bye,<br>
> Rouslan<br>
><br>
> [0]: <a href="https://github.com/roccivic/phpmyadmin/tree/frames-removal" target="_blank">https://github.com/roccivic/phpmyadmin/tree/frames-removal</a><br>
><br>
> Problem 2# has been fixed.<br>
> Thanks Rouslan.<br>
<br>
</div>Hi Thilina,<br>
<br>
Same problem in copy table form:<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/operations.lib.php#L1036" target="_blank">https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/operations.lib.php#L1036</a><br>
<br>
Could you please do a quick grep to see if there are more instances of<br>
the same elsewhere?<br></blockquote><div> </div><div>Thanks Rouslan, I did the changes.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Lastly, IMO, the ternary operator operator does no favours to us in<br>
terms of code readability there.<br>
<br></blockquote><div> </div></div><div><br></div>-- <br><font face="georgia, serif">Regards.</font><br><br><font face="'trebuchet ms', sans-serif" color="#660000">Thilina Abeyrathna</font><font face="georgia, serif"><br>
</font><div><font face="georgia, serif" size="1">Gtalk : thilinaabeyrathna</font></div><div><font face="georgia, serif" size="1">skype: thilinabuddika88</font></div><div><font face="georgia, serif"><font size="1"><a href="http://thilinaa.wordpress.com" target="_blank">thilinaa.wordpress.com</a> <br>
</font><br></font></div><br>