Hi,<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
>
> I recently involved in fixing bug [0]. While fixing it, I was bit<br>
> confused that, PMA renders user input as it is while inline editing,<br>
> without getting real value saved in database. Yes, PMA do this after<br>
> checking the result of query execution function. But though result is<br>
> not an error, it doesn't mean that data is saved as it was. Mainly this<br>
> happens with numeric fields. Just type decimal value for column with<br>
> integer type and see what happens after refresh. As mentioned bug<br>
> description, MySQL truncate numeric data (not sure about other data<br>
> types) without noticing.<br>
><br>
> Of course checking again the saved value is cost. But it's really odd to<br>
> see a less precise data, represent the real data. I think it's better to<br>
> clearly identify the data types, with or without having this behaviour.<br>
> So that, we can only recheck needed columns.<br>
><br>
> When introducing inline edit functionality, this may have been<br>
> discussed. But I think better to discuss again. What do you think ?<br>
<br>
<br>
</div>It sounds quite simple to me, so not sure if I'm missing something here.<br>
<br>
Anyway, we could just check if any warnings were generated by the query<br>
(mysql_warning_count or similar function). If yes, then select the value<br>
and send it to the client along with the response. Right?<br>
</blockquote><div><br>Rouslan,<br>Yeah, there are functions to detect warnings. But unfortunately this kind of queries doesn't throw warnings. As I mentioned MySQL doesn't notice about the data truncation.<br><br>
I'll do this (re checking and return saved value) only for numeric since identified only those.<br>Any objections ?<br> <br>Regards !<br></div></div>-- <br><font size="4">Chanaka Dharmarathna<br></font><div><font color="#999999"><b>Virtusa (Pvt) Ltd. | </b></font><b style="color:rgb(153,153,153)">Sri Lanka</b></div>