<div>Hi,</div><div><span style="color: rgb(160, 160, 168); "><br></span></div><div><span style="color: rgb(160, 160, 168); ">On Monday, 1 July 2013 at 8:37 PM, Marc Delisle wrote:</span></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>adam a écrit :</div><blockquote type="cite"><div><div>Hi,</div><div><br></div><blockquote type="cite"><div><div>Dne Mon, 1 Jul 2013 22:17:44 +0800</div><div>adam <<a href="mailto:adamgsoc2013@gmail.com">adamgsoc2013@gmail.com</a>> napsal(a):</div><div><br></div><blockquote type="cite"><div><div>Hi Michal,</div><div><br></div><blockquote type="cite"><div><div>Hi</div><div><br></div><div>Dne Wed, 26 Jun 2013 10:05:36 -0400</div><div>Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> napsal(a):</div><div><br></div><blockquote type="cite"><div><div>I don't understand why I have different results when running phpunit on </div><div>the ayushchd/unit_testing branch (5 failures) and on the master branch </div><div>(with Michal's merge 10 minutes ago), which gives me 16 failures.</div></div></blockquote><div>Most of the differences were most likely caused by different error</div><div>reporting level in PHP. Since 68b10df I've enabled E_ALL error</div><div>reporting in testsuite, so the number of failed tests should be same</div><div>regardless this factor.</div><div><br></div><div>This also leads to 30! failed tests on Travis (the CI server did see</div><div>these failures before).</div><div><br></div><div>As most of these tests were written by Adam, please look at them and</div><div>fix them ASAP.</div></div></blockquote><div>Look at the failures,</div><div><a href="https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/8620957">https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/8620957</a></div><div><br></div><div>It is from two files: </div><div>/home/travis/build/phpmyadmin/phpmyadmin/test/libraries/PMA_ConfigFile_test.php</div><div>/home/travis/build/phpmyadmin/phpmyadmin/test/libraries/PMA_Tracker_test.php</div><div><br></div><div>In fact, Asyush worked on these two files:</div><div><a href="https://github.com/phpmyadmin/phpmyadmin/commits/master/test/libraries/PMA_ConfigFile_test.php">https://github.com/phpmyadmin/phpmyadmin/commits/master/test/libraries/PMA_ConfigFile_test.php</a></div><div><a href="https://github.com/phpmyadmin/phpmyadmin/commits/master/test/libraries/PMA_Tracker_test.php">https://github.com/phpmyadmin/phpmyadmin/commits/master/test/libraries/PMA_Tracker_test.php</a></div></div></blockquote><div>Sorry for overlooking (I mangled file names in my head between looking</div><div>at Travis and Git). Indeed these were done by Ayush, so the complain</div><div>should have gone to him :-).</div></div></blockquote><div><br></div><div>I sent a pull request:</div><div><a href="https://github.com/phpmyadmin/phpmyadmin/pull/471">https://github.com/phpmyadmin/phpmyadmin/pull/471</a></div><div><br></div><div>This can fix most errors. thanks</div></div></blockquote><div><br></div><div>I am puzzled. With my current master at </div><div>864cf690d8a7d10e37a56113d396f7c26630a9bb, phpunit 3.7.21 and PHP 5.4.10, </div><div>I still have 18 failures.</div><div><br></div><div>Here is the first example:</div><div><br></div><div>There were 18 failures:</div><div><br></div><div>1) ImportCsv_Test::testDoImport</div><div>Failed asserting that '</div><div> RENAME TABLE `pma_test`.`table1`</div><div> TO `pma_test`.`table3`;CREATE TABLE IF NOT EXISTS </div><div>`pma_test`.`TABLE 1` (`COL 1` varchar(48)) DEFAULT CHARACTER SET utf8 </div><div>COLLATE utf8_general_ci;INSERT INTO `pma_test`.`TABLE 1` (`COL 1`) </div><div>VALUES ('1,dbbase,,ddd,SELECT * FROM `db_content` WHERE 1');' contains </div><div>"CREATE DATABASE IF NOT EXISTS `CSV_DB` DEFAULT CHARACTER".</div><div><br></div><div>phpmyadmin/test/classes/plugin/import/ImportCsv_test.php:134</div><div>/usr/local/bin/phpunit:46</div><div><br></div><div><br></div></div></div></span></blockquote><div>I am having similar results at my end too. Here[0] is the output on my machine when I run phpunit. I reckon this is something to do with the backup globals flag. Is it now set to true on the CI server? Additionally, I did not get the "Undefined index: server" error on my machine, but that could be because on my machine, $GLOBALS['server'] was being set somewhere else during phpunit's run while on the server it wasn't.</div><div><br></div><div>[0] <a href="https://gist.github.com/ayushchd/5901501">https://gist.github.com/ayushchd/5901501</a></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div></div><div>-- </div><div>Marc Delisle</div><div><a href="http://infomarc.info">http://infomarc.info</a></div><div><br></div><div>------------------------------------------------------------------------------</div><div>This <a href="http://SF.net">SF.net</a> email is sponsored by Windows:</div><div><br></div><div>Build for Windows Store.</div><div><br></div><div><a href="http://p.sf.net/sfu/windows-dev2dev">http://p.sf.net/sfu/windows-dev2dev</a></div><div>_______________________________________________</div><div>Phpmyadmin-devel mailing list</div><div><a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a></div><div><a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>