<div>Thanks. Noted :)
</div>
<div><div><br></div><div>-- </div><div>Ayush Chaudhary</div><div><br></div></div>
<p style="color: #A0A0A8;">On Monday, 8 July 2013 at 8:23 PM, Dieter Adriaenssens wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>2013/7/8 Ayush Chaudhary <<a href="mailto:ayushchd@gmail.com">ayushchd@gmail.com</a>>:</div><blockquote type="cite"><div><div><br></div><div>On Wednesday, 3 July 2013 at 8:41 PM, Madhura Jayaratne wrote:</div><div><br></div><div><br></div><div><br></div><div><br></div><div>On Wed, Jul 3, 2013 at 1:59 PM, Ayush Chaudhary <<a href="mailto:ayushchd@gmail.com">ayushchd@gmail.com</a>> wrote:</div><div><br></div><div>Hi,</div><div><br></div><div>On Wednesday, 3 July 2013 at 2:08 PM, Dieter Adriaenssens wrote:</div><div><br></div><div>2013/7/3 Ayush Chaudhary <<a href="mailto:ayushchd@gmail.com">ayushchd@gmail.com</a>>:</div><div><br></div><div>Hi,</div><div><br></div><div>Is there a reason why validation.lib.php is not a class with public static</div><div>method? Is it okay to convert it to a class with all methods' access</div><div>specifier as public static?</div><div><br></div><div><br></div><div>Did you mean the PMA_SQLValidator class in</div><div>libraries/sqlvalidator.class.php? I didn't find a validation.lib.php,</div><div>or something similar, in the PMA codebase, that contains a class.</div><div>(libraries/config/validate.lib.php doesn't contain a class)</div><div><br></div><div>Sorry for not being clear. I was referring to the library</div><div>libraries/config/validate.lib.php. I am currently writing tests for</div><div>libraries/config/FormDisplay.class.php, and there are numerous calls to</div><div>functions from validate.lib.php which cannot be mocked because they are not</div><div>contained in a class. Also, the same issue holds for</div><div>libraries/config/FormDisplay.tpl.php</div><div><br></div><div><br></div><div>I am in favor of putting these functions into a class as static methods.</div><div><br></div><div>Waiting for more confirmations :)</div></div></blockquote><div><br></div><div>I agree too.</div><div><br></div><div>BTW : In an ideal world, everyone on this mailing list, or at least</div><div>the core developers would have voted in favor or against. In practice,</div><div>if nobody objects within a few days, it is a silent agreement. ;)</div><div><br></div><div><br></div><div>Kind regards,</div><div>Dieter Adriaenssens</div><div><br></div><div>------------------------------------------------------------------------------</div><div>This <a href="http://SF.net">SF.net</a> email is sponsored by Windows:</div><div><br></div><div>Build for Windows Store.</div><div><br></div><div><a href="http://p.sf.net/sfu/windows-dev2dev">http://p.sf.net/sfu/windows-dev2dev</a></div><div>_______________________________________________</div><div>Phpmyadmin-devel mailing list</div><div><a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a></div><div><a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>