<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">2014-02-17 13:56 GMT+01:00 Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Minhaz A V a écrit :<br>
<div class="">> Hi,<br>
> Do I have to add it to bug tracker first or I can directly send the pull<br>
> request!<br>
><br>
<br>
</div>Hi,<br>
(Please use bottom-posting on this list).<br>
<br>
This is not a bug, it's a speed improvement.<br></blockquote><div><br></div><div>I would add: don't forget to sign your commit with the -s option.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class=""><br>
><br>
> Minhaz<br>
> <a href="http://cistoner.org" target="_blank">cistoner.org</a><br>
><br>
><br>
> On Sun, Feb 16, 2014 at 8:55 PM, Hugues Peccatte<br>
> <<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a>>wrote:<br>
><br>
>> Hi,<br>
>><br>
>> 2014-02-14 23:21 GMT+01:00 Minhaz A V <<a href="mailto:minhazav@gmail.com">minhazav@gmail.com</a>>:<br>
>><br>
>> Hi,<br>
</div>>>> I was going through the codes and at many places I found use of *count()<br>
>>> *inside the *for* statement.<br>
>>> I think statements like<br>
>>><br>
>>> *for($i = 0; $i < count($arr); $i++)*<br>
<div class="">>>> should be converted with statements like<br>
>>><br>
</div>>>> *$len = count($arr);*<br>
>>> *for($i = 0; $i < $len; $i++)*<br>
<div class="im HOEnZb">>>><br>
>>> this would help us speed up the whole phpMyAdmin system.<br>
>>><br>
>> You're right. The second write is better. But as you said in your second<br>
>> mail, we try to avoid the first syntax.<br>
>> If you find the use of count into a loop, please fix it a send a pull<br>
>> request.<br>
>><br>
>> Thanks,<br>
>> Hugues.<br>
>><br>
<br>
<br>
<br>
</div><span class="HOEnZb"><font color="#888888">--<br>
Marc Delisle<br>
<a href="http://infomarc.info" target="_blank">http://infomarc.info</a> | <a href="http://phpmyadmin.net" target="_blank">http://phpmyadmin.net</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
------------------------------------------------------------------------------<br>
Android apps run on BlackBerry 10<br>
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.<br>
Now with support for Jelly Bean, Bluetooth, Mapview and more.<br>
Get your Android app in front of a whole new audience. Start now.<br>
<a href="http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk" target="_blank">http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra">Hugues.</div></div>