<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-03-03 21:14 GMT+01:00 Hugues Peccatte <span dir="ltr"><<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-03-03 18:47 GMT+01:00 Hugues Peccatte <span dir="ltr"><<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>></span>:<div class="">
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi,<div><div class="gmail_extra"><br><div class="gmail_quote">
2014-03-03 14:43 GMT+01:00 Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span>:<div><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><br>
<br>
On 2/28/14 7:52 AM, Marc Delisle wrote:<br>
> Hugues Peccatte a écrit :<br>
>> Hi everyone,<br>
>><br>
>> I just implemented the new feature "Load/save Query-By-Example" (see ticket<br>
>> <a href="https://sourceforge.net/p/phpmyadmin/feature-requests/569/" target="_blank">https://sourceforge.net/p/phpmyadmin/feature-requests/569/</a> and pull request<br>
>> <a href="https://github.com/phpmyadmin/phpmyadmin/pull/958" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/958</a>).<br>
>><br>
>> In the UI interface, I used the terms "New search" and "Saved searches".<br>
>> Marc proposed to use the terms "New search definition" and "Saved search<br>
>> definitions".<br>
>><br>
>> Which one do you prefer? Which one is the more understandable for an<br>
>> english people? Do you have another interesting proposal?<br>
>><br>
>> Thanks for your feedback.<br>
>><br>
>> Hugues.<br>
><br>
> Hi,<br>
> it could also be "New search bookmark", "Saved search bookmarks", ...<br>
<br>
</div>Of the three choices proposed, I most prefer "New search bookmark" and<br>
"Saved search bookmarks". Using the word "query" instead of "search"<br>
also fits nicely.<br></blockquote><div><br></div></div><div>In SQL tab, there is a text "Bookmark this SQL query". Couldn't it lead to confusion?</div><div>I agree with "search bookmark". So I'll change this.</div>
</div></div></div></div></blockquote><div><br></div></div><div>I changed it, locally. I used "bookmarked search". Is it ok ?</div><div class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
A few things I noticed while testing this feature:<br>
<br>
1) When attempting to save a bookmark without providing a name, instead<br>
of "Missing information to save the search." we should be more specific<br>
and instead say "Please provide a name for this bookmarked query."<br></blockquote><div><br></div></div><div>I agree. I'll try to implement this.</div></div></div></div></div></blockquote><div><br></div></div>
<div>
Done.</div><div class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>
<div class="gmail_extra">
<div class="gmail_quote"><div> </div></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
In an ideal world, IMO, the proper field should then get focus and have<br>
a light red background until the user starts to type. I don't believe we<br>
do that anywhere, but it is a good way to draw the user's attention to<br>
the blank and required field.<br></blockquote><div><br></div></div><div>I agree also. I'll try to see if I can do something about this.</div></div></div></div></div></blockquote><div><br></div></div><div>I did it, but there is a "problem"… The field is focused, but behind the "PMA_ajaxShowMessage". So I click on the popin to close it… and lose the focus…</div>
<div>The only thing that I can do is to add a red border to the field. As the content of the page is reloaded when submitting the form, the field won't stay red too long.</div><div><br></div><div>I'm working at the same time and I did something:</div>
<div>- when having an error, I receive the id of a field (already done to focus the element)</div><div>- I remove the class "error" of all inputs in the page</div><div>- I had the class "error" to the field</div>
<div><br></div><div>So even if there are many errors on different fields without reload, only one field will stay with the "error" class.</div><div><br></div><div>What do you think about this please?</div><div class="">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote">
<div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
2) I think we should we prompt the user before saving over an existing<br>
bookmark.<br></blockquote><div><br></div></div><div>Currently, you can't use a bookmark name already used by this user on this DB. Do you mean that we should authorize to overwrite a name if the user agree?</div><div>
<div> </div></div></div></div></div></div></blockquote><div><br></div></div><span class="HOEnZb"><font color="#888888"><div>Hugues. </div></font></span></div></div></div>
</blockquote></div><br></div><div class="gmail_extra">Hi,</div><div class="gmail_extra"><br></div><div class="gmail_extra">It had been merged, so you can try it not to fill the name and click on "Save".</div><div class="gmail_extra">
<br></div><div class="gmail_extra">Hugues.</div></div>