<div dir="ltr">Hi Abhishek,<div><br></div><div>Yes you are right this is not the proper way as the UI is not consistent. I am letting you know some of the discussion that was happening regarding this bug.</div><div><font face="arial, sans-serif">1. Option 1: Show both Update (The latest update query) and Select query, I felt this was pointless as the query box in browse mode is relevant only if it shows the select query.</font></div>
<div><font face="arial, sans-serif">2. Option 2: Use something like I did in the pull request along with all the update queries being logged. </font></div><div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Share if you have any better ideas?</font></div>
<div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Regards</font></div><div><font face="arial, sans-serif">Krtin</font></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Mar 5, 2014 at 5:25 PM, Abhishek Kandoi <span dir="ltr"><<a href="mailto:abhikandoi2000@gmail.com" target="_blank">abhikandoi2000@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>While examining the <b>bug 4301</b>, I found a fundamental problem with the query result messages (those with id result_query).</div><div><br></div><div>The problem is that in some cases there are multiple result query messages that have to be displayed. For eg: when a row is edited (using the <b>Edit </b>link of a particular row on the browse table page) two result queries are displayed. The first is an <b>UPDATE</b> query and the other is a <b>SELECT</b> query.</div>
<div><br></div><div>The corresponding HTML for this contains two <b>div</b>s with the same id (i.e. <b>result_query</b>). This is invalid html as an <b>id</b> is supposed to be unique to an element and must only identify a single element.</div>
<div><br></div><div>Regarding the bug 4301, there is a pull request from <b>krtin </b>available here <a href="https://github.com/phpmyadmin/phpmyadmin/pull/1006" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/1006</a>.</div>
<div><br></div><div>But according to the standards this is not the proper way to fix this bug. I would like to re-factor the code corresponding to the multiple-element-with-same-id problem and then fix this bug accordingly.</div>
<div><br></div><div>This pull request does solve the problem but, in the long run it may be problematic due to its inconsistency with the overall UI/UX of phpMyAdmin (it uses animation to display the UPDATE query for a few seconds followed by the SELECT query).</div>
<div><br></div><div>Any thoughts on this?</div><span class="HOEnZb"><font color="#888888"><div><br></div>-- <br><div dir="ltr">Abhishek Kandoi<br>Second Year, Computer Science and Engineering<br>Indian Institute of Technology Roorkee<br>
About Me : <a href="http://about.me/kandoiabhi" target="_blank">about.me/kandoiabhi</a><div>
I blog at: <a href="http://abhikandoi.in" target="_blank">abhikandoi.in</a></div></div>
</font></span></div>
<br>------------------------------------------------------------------------------<br>
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.<br>
With Perforce, you get hassle-free workflows. Merge that actually works.<br>
Faster operations. Version large binaries. Built-in WAN optimization and the<br>
freedom to use Git, Perforce or both. Make the move to Perforce.<br>
<a href="http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk" target="_blank">http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk</a><br>_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
<br></blockquote></div><br></div>