<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Hi,</div><div class="gmail_quote"><br></div><div class="gmail_quote">2014-03-05 16:54 GMT+01:00 Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5"><br>
<br>
On 3/4/14 6:38 PM, Isaac Bennetch wrote:<br>
> Hi Hugues, very nice work on this. I have a few comments below:<br>
><br>
> On 3/3/14 3:14 PM, Hugues Peccatte wrote:<br>
>> 2014-03-03 18:47 GMT+01:00 Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a><br>
>> <mailto:<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a>>>:<br>
>><br>
>> Hi,<br>
>><br>
>> 2014-03-03 14:43 GMT+01:00 Isaac Bennetch <<a href="mailto:bennetch@gmail.com">bennetch@gmail.com</a><br>
>> <mailto:<a href="mailto:bennetch@gmail.com">bennetch@gmail.com</a>>>:<br>
>><br>
>><br>
>><br>
>> On 2/28/14 7:52 AM, Marc Delisle wrote:<br>
>> > Hugues Peccatte a écrit :<br>
>> >> Hi everyone,<br>
>> >><br>
>> >> I just implemented the new feature "Load/save<br>
>> Query-By-Example" (see ticket<br>
>> >> <a href="https://sourceforge.net/p/phpmyadmin/feature-requests/569/" target="_blank">https://sourceforge.net/p/phpmyadmin/feature-requests/569/</a><br>
>> and pull request<br>
>> >> <a href="https://github.com/phpmyadmin/phpmyadmin/pull/958" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/958</a>).<br>
>> >><br>
>> >> In the UI interface, I used the terms "New search" and "Saved<br>
>> searches".<br>
>> >> Marc proposed to use the terms "New search definition" and<br>
>> "Saved search<br>
>> >> definitions".<br>
>> >><br>
>> >> Which one do you prefer? Which one is the more understandable<br>
>> for an<br>
>> >> english people? Do you have another interesting proposal?<br>
>> >><br>
>> >> Thanks for your feedback.<br>
>> >><br>
>> >> Hugues.<br>
>> ><br>
>> > Hi,<br>
>> > it could also be "New search bookmark", "Saved search<br>
>> bookmarks", ...<br>
>><br>
>> Of the three choices proposed, I most prefer "New search<br>
>> bookmark" and<br>
>> "Saved search bookmarks". Using the word "query" instead of "search"<br>
>> also fits nicely.<br>
>><br>
>><br>
>> In SQL tab, there is a text "Bookmark this SQL query". Couldn't it<br>
>> lead to confusion?<br>
>> I agree with "search bookmark". So I'll change this.<br>
>><br>
>><br>
>> I changed it, locally. I used "bookmarked search". Is it ok ?<br>
>><br>
><br>
> Yes, this seems good to me now.<br>
><br>
>><br>
>><br>
>> A few things I noticed while testing this feature:<br>
>><br>
>> 1) When attempting to save a bookmark without providing a name,<br>
>> instead<br>
>> of "Missing information to save the search." we should be more<br>
>> specific<br>
>> and instead say "Please provide a name for this bookmarked query."<br>
>><br>
>><br>
>> I agree. I'll try to implement this.<br>
>><br>
>><br>
>> Done.<br>
>><br>
>><br>
><br>
> I think you may be using the wrong dialog here; it is saying "MySQL<br>
> said" and has a link to the MySQL documentation. Otherwise I like this.<br></div></div></blockquote><div><br></div><div>I replaced it by the good popup (I hope…).</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">
>><br>
>><br>
>><br>
>> In an ideal world, IMO, the proper field should then get focus<br>
>> and have<br>
>> a light red background until the user starts to type. I don't<br>
>> believe we<br>
>> do that anywhere, but it is a good way to draw the user's<br>
>> attention to<br>
>> the blank and required field.<br>
>><br>
>><br>
>> I agree also. I'll try to see if I can do something about this.<br>
>><br>
>><br>
>> I did it, but there is a "problem"… The field is focused, but behind the<br>
>> "PMA_ajaxShowMessage". So I click on the popin to close it… and lose the<br>
>> focus…<br>
>> The only thing that I can do is to add a red border to the field. As the<br>
>> content of the page is reloaded when submitting the form, the field<br>
>> won't stay red too long.<br>
>><br>
>> I'm working at the same time and I did something:<br>
>> - when having an error, I receive the id of a field (already done to<br>
>> focus the element)<br>
>> - I remove the class "error" of all inputs in the page<br>
>> - I had the class "error" to the field<br>
>><br>
>> So even if there are many errors on different fields without reload,<br>
>> only one field will stay with the "error" class.<br>
>><br>
>> What do you think about this please?<br>
>><br>
><br>
> It's an interesting problem and I'm not thrilled with the results<br>
> (because of the limitations you mention above). Perhaps it's something<br>
> we should leave alone for now and I'll open a feature request with a<br>
> list of everywhere that could benefit from this.<br>
<br>
</div></div>Take a look at the "Create database" form by clicking the Databases tab<br>
of the main page. Attempting to create a database with no name gives a<br>
nice red highlight and "Please fill out this field" popup. Hopefully<br>
that clears up what I meant; but we can simply add this form to the list<br>
at <a href="https://sourceforge.net/p/phpmyadmin/feature-requests/1513/" target="_blank">https://sourceforge.net/p/phpmyadmin/feature-requests/1513/</a> if you'd<br>
like.<br></blockquote><div><br></div><div>I think this is a browser design. On Chrome, the field only has a tip.</div><div>This is displayed by the attribute "required". I don't think that I can use it because there are some cases where we don't need to set a name.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
>><br>
>> 2) I think we should we prompt the user before saving over an<br>
>> existing<br>
>> bookmark.<br>
>><br>
>><br>
>> Currently, you can't use a bookmark name already used by this user<br>
>> on this DB. Do you mean that we should authorize to overwrite a name<br>
>> if the user agree?<br>
><br>
> I can only speak about how I expect it to work, and I now understand how<br>
> it is meant to work, but it seems a bit confusing. You're allowing the<br>
> user to rename their search by typing in a new name to "searchName", but<br>
> to create a modified copy of an existing query a user would have to<br>
> select "New bookmark" from the "searchId" dropdown. As a user, I<br>
> expected it to create a new bookmark with the new name, leaving the old<br>
> one intact. Yes, I realize the submit button says "Save bookmark" which<br>
> is a clue, but I ignored the label and pressed on, convinced I knew<br>
> better :-D<br>
><br>
> I believe people are more likely to want to create a copy of a bookmark<br>
> than rename one (renaming can essentially be done by creating a copy and<br>
> removing the old one, which isn't ideal but I think is pretty well<br>
> understood).<br>
><br>
> I'd appreciate some other thoughts about this, especially if I'm wrong<br>
> here :)<br></div></div></blockquote><div><br></div><div>I believe that I don't understand one part…</div><div>[…]</div><div>Oh… I read it again. Maybe I understood this time…</div><div>After loading a search and setting a new name, you expect to have the first one and the new one with the new name. I think that I got it !</div>
<div><br></div><div>I wait for other feedbacks before changing the behavior, but it could be interesting too. :)<br></div><div><br></div><div>Hugues.</div></div></div></div>