<div dir="ltr">2014-04-17 23:38 GMT+02:00 Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Le 2014-04-17 13:43, Hugues Peccatte a écrit :<br>
<div class="">> 2014-04-17 14:07 GMT+02:00 Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a><br>
</div>> <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>>>:<br>
<div class="">><br>
> Hugues Peccatte a écrit :<br>
> > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte<br>
</div>> <<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a>>>:<br>
<div class="">> ><br>
> >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte<br>
</div>> <<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a>>>:<br>
<div class="">> >><br>
> >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <<a href="mailto:michal@cihar.com">michal@cihar.com</a><br>
</div>> <mailto:<a href="mailto:michal@cihar.com">michal@cihar.com</a>>>:<br>
<div class="">> >>> Hi<br>
> >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200<br>
> >>>> Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a><br>
</div>> <mailto:<a href="mailto:hugues.peccatte@gmail.com">hugues.peccatte@gmail.com</a>>> napsal(a):<br>
<div><div class="h5">> >>>><br>
> >>>>> I was looking for something more implicit, so we wouldn't have to<br>
> >>>> change<br>
> >>>>> the calls to $.get. But that seems to be difficult, so your<br>
> solution<br>
> >>>> might<br>
> >>>>> be the best.<br>
> >>>> Well we can also override jQuery.get to do what we want (basically<br>
> >>>> just wrapper around original code to do compose the URL<br>
> correctly. That<br>
> >>>> might be cleaner approach.<br>
> >>>><br>
> >>> Thanks for this very interesting feedback !<br>
> >>> I found this :<br>
> >>><br>
> <a href="http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm" target="_blank">http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm</a><br>
> >>><br>
> >>> I'll try to override the $.get method by this way.<br>
> >>><br>
> >> It's done… I overwrote $.get… But there is many Jquery methods<br>
> which use<br>
> >> the "&" as an URL parameter separator… I would have love that<br>
> they have a<br>
> >> $.getArgSeparator, like pMA, so we could overwrite this method<br>
> only! :)<br>
> >> We can overwrite all methods which use "&". But when we'll want<br>
> to change<br>
> >> the Jquery version, it will be a mess.<br>
> >><br>
> >> Shall we continue to search a way to use another separator than "&"?<br>
> >> Do you want we to push my work on my repository, so you can see<br>
> what I've<br>
> >> done?<br>
> >><br>
> >><br>
> > I didn't wait for an answer. If you want to check:<br>
> > <a href="https://github.com/Tithugues/phpmyadmin/tree/b3733" target="_blank">https://github.com/Tithugues/phpmyadmin/tree/b3733</a><br>
> ><br>
> > Hugues.<br>
><br>
> Hi Hugues,<br>
> I have started to review the code; so far it looks fine.<br>
><br>
> In js/messages.php, maybe it would be more consistent to call<br>
> PMA_URL_getArgSeparator() ?<br>
><br>
><br>
> You're right. It's done.<br>
><br>
> Hugues.<br>
<br>
</div></div>Ok. Feel free to merge to master; I'll release -beta1 afterwards.<br></blockquote><div><br></div><div>I really can't… There is still issues with Jquery methods which use the "&". </div><div>
That why I asked:</div><div>Shall we continue to search a way to use another separator than "&"?</div><div>Override all methods? I don't think this is a good thing…</div><div><br></div><div>Thanks for your feedback and code review.<br>
</div><div><br></div><div>Hugues.</div></div>