<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 27, 2014 at 10:45 PM, Hugues Peccatte <span dir="ltr"><<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-05-27 18:53 GMT+02:00 Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span>:<div class="">
<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

Hi,<br>
I found out that some bug reports by Scrutinizer are wrong. For example,<br>
in [0], the PHP Analyzer reports that you cannot assign a return value<br>
because mysqli_init() always returns null, which is not the case.<br>
<br>
[0]<br>
<a href="https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/dbi/DBIMysqli.class.php?selectedLabels[0]=9&orderField=path&order=asc" target="_blank">https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/dbi/DBIMysqli.class.php?selectedLabels[0]=9&orderField=path&order=asc</a><br>



<br>
--<br>
Marc Delisle (phpMyAdmin)</blockquote><div>  </div></div></div>Hi,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Another one is this one: <a href="https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DBQbe.class.php?selectedAuthors%5B0%5D=hugues.peccatte%40gmail.com&orderField=path&order=asc" target="_blank">https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DBQbe.class.php?selectedAuthors%5B0%5D=hugues.peccatte%40gmail.com&orderField=path&order=asc</a></div>


<div class="gmail_extra">Scrutinizer believes that the method isn't doing anything, but it is overwriting $_REQUEST. It seems that Scrutinizer doesn't understand this.</div><span class=""><font color="#888888"><div class="gmail_extra">
<br></div><div class="gmail_extra">

H.</div></font></span></div>
<br></blockquote></div><br><br></div><div class="gmail_extra">Hi,<br><br>There are many more such issues which includes: <br><br>1) function duplication in which 2 functions which are completely different are reported as duplicated ones. For e.g. <a href="https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/indices/152775/duplications/2920437">https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/indices/152775/duplications/2920437</a><br>
<br>2) <span class=""><a href="https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DisplayResults.class.php?selectedAuthors[0]=chirayu.chiripal%40gmail.com&orderField=path&order=asc">https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DisplayResults.class.php?selectedAuthors[0]=chirayu.chiripal%40gmail.com&orderField=path&order=asc</a><br>
The method getMIMEtype cannot be called on<code title="$transformation_plugin"></code> $transformation_plugin (of type string). In the if condition it is checked first that </span><span class=""><span class=""><code title="$transformation_plugin"></code></span>$transformation_plugin is of type object and then method getMIMEtype</span> is called.<br>
<br></div><div class="gmail_extra">There are more than one instances of reports which are mentioned above.They need to be reported as false positives.<br></div><div class="gmail_extra"><br>-- <br><div dir="ltr">Regards,<br>
Chirayu Chiripal<br>phpMyAdmin Intern - Google Summer of Code 2014<br><a href="https://chirayuchiripal.wordpress.com/" target="_blank">https://chirayuchiripal.wordpress.com/</a><br></div>
</div></div>