<div dir="ltr">Hi,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 3, 2014 at 12:15 PM, Dhananjay Nakrani <span dir="ltr"><<a href="mailto:dhananjaynakrani@gmail.com" target="_blank">dhananjaynakrani@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hello everyone,<div><br></div><div>I'm trying to fix the failing tests for the code I developed. I need a little help from the community in it.</div>
<div><br></div><div>I am providing appropriate new data in the data provider in 'PMA_Error_Handler_Test::providerForTestHandleError()' [0]. That data contains a string with empty single quotes (<font face="courier new, monospace">''</font>) in it (see, Line#98 [1] ). So, I escaped it with backslash (\) and passed it as (<font face="courier new, monospace">\'\'</font>). But that gives a very weird behavior. See Line#342 [2] of the log where it starts repeating the string again in itself. It seems to be going in recursion somewhere. </div>
<div><br></div><div>Am I doing anything wrong Or is it just a bug in PHPUnit? </div><div>Is there anyway I can fix this??</div><div><br></div><div><br></div><div>[0]: <a href="https://github.com/dhananjay92/phpmyadmin/blob/dhananjay-gsoc-dev/test/classes/PMA_Error_Handler_test.php#L87" target="_blank">https://github.com/dhananjay92/phpmyadmin/blob/dhananjay-gsoc-dev/test/classes/PMA_Error_Handler_test.php#L87</a></div>
<div>[1]: <a href="https://github.com/dhananjay92/phpmyadmin/blob/dhananjay-gsoc-dev/test/classes/PMA_Error_Handler_test.php#L98" target="_blank">https://github.com/dhananjay92/phpmyadmin/blob/dhananjay-gsoc-dev/test/classes/PMA_Error_Handler_test.php#L98</a></div>
<div>[2]: <a href="https://travis-ci.org/dhananjay92/phpmyadmin/jobs/26636648#L342" target="_blank">https://travis-ci.org/dhananjay92/phpmyadmin/jobs/26636648#L342</a></div><div><br></div><div><br></div><div>Thanks,</div>
<div>
Dhananjay Nakrani.</div>
</div>
<br></blockquote></div><br clear="all"></div><div class="gmail_extra">I don't think its a bug in PHPUnit. Its happening because of backtrace information part in error handler due to which whatever parameters you are passing to testGetDispErrorsForDisplayFalse() will reappear in $output in backtrace section. Moreover, the parameters will be converted using htmlspecialchars(). As the 6th parameter ($output_hide) of the function contains html tags it will get converted by htmlspecialchars and then added to the $output (this is the thing that appears at L342 of [2] you mentioned before). So, you have to change your 6th parameter of data set #0 so that it does not contain html tags. Note that you cannot even replace your parameter with htmlspecialchars() equivalent string like string containing < or > because each '&' of that string will again be replaced by & again and again. Hence, change your test data accordingly.<br>
<br></div><div class="gmail_extra">-- <br><div dir="ltr">Regards,<br>Chirayu Chiripal<br>phpMyAdmin Intern - Google Summer of Code 2014<br><a href="https://chirayuchiripal.wordpress.com/" target="_blank">https://chirayuchiripal.wordpress.com/</a><br>
</div>
</div></div>