<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 16, 2014 at 7:53 PM, Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><br>
<br>
On 6/16/14 9:59 AM, Chirayu Chiripal wrote:<br>
><br>
><br>
><br>
> On Mon, Jun 16, 2014 at 7:14 PM, Isaac Bennetch <<a href="mailto:bennetch@gmail.com">bennetch@gmail.com</a><br>
</div><div><div class="h5">> <mailto:<a href="mailto:bennetch@gmail.com">bennetch@gmail.com</a>>> wrote:<br>
><br>
> Hello,<br>
><br>
> On 6/16/14 8:09 AM, Chirayu Chiripal wrote:<br>
> > Hello Isaac Sir,<br>
> ><br>
> > Please review this branch:<br>
> <a href="https://github.com/D-storm/phpmyadmin/tree/FR-755" target="_blank">https://github.com/D-storm/phpmyadmin/tree/FR-755</a><br>
> ><br>
> > Tasks to be done yet (Will be pushed soon):<br>
> ><br>
> > 1) Fix failing test cases and improve test cases.<br>
><br>
> Yes, this is quite good but I have a few minor suggestions.<br>
><br>
> 1) There should be some way to inform the user once they've selected<br>
> this option. I have a few ideas about this but don't prefer one over the<br>
> other at the moment.<br>
><br>
> What do you think of adding a checkbox in front of the text "Change<br>
> Database/Table/Column names". When the user clicks the checkbox or the<br>
> text, the dialog appears; once the dialog is closed the checkbox is<br>
> checked.<br>
><br>
> An alternative is making an icon appear in front of the text (a green<br>
> checkbox, probably) once the dialog is closed.<br>
><br>
> I think it's important to give visual feedback that the feature is going<br>
> to be active.<br>
><br>
><br>
> I think I'll go with green checkbox.<br>
><br>
><br>
> 2) I suggest adding a "reset" button to the dialog which would clear all<br>
> values. I also think the upper-right X (close button) should abandon any<br>
> changes made; right now it saves those changes.<br>
><br>
><br>
> Actually, there is nothing like save here, those input fields (initially<br>
> hidden) are just displayed when dialog opens and hides when dialog<br>
> closes but I'll see how can it be done. Should it reset every field<br>
> i.e. all databases/tables/columns inputs?<br>
> Also, then we should change "close" button to "save & close".<br>
<br>
</div></div>Ah, I see. What does everyone else think -- should we allow the user to<br>
reset to a blank dialog, and if so should it affect only the displayed<br>
table or all tables? I think a button with text "Reset all" that resets<br>
all of the form fields might be the best way here, but of course I'm<br>
open to other suggestions.<br>
<br>
"Save and close" was my original thought, but now that I see how the<br>
form works I have doubts (changes are saved immediately rather than when<br>
pressing the "Save and close" button). To me, when I saw "Close" by<br>
itself I wasn't sure if that meant it would accept my changes or discard<br>
them -- but I didn't realize changes are essentially saved immediately.<br>
<br>
Here's what I think we should ideally do, without thinking about whether<br>
it's actually possible or easy to accomplish:<br>
<br>
* A "Reset all" button that resets all possible rename fields to blank.<br>
* Renaming the "Close" button to "Save and close"<br>
* Removing the upper-right X of the dialog so that we remove the<br>
question about what happens in this case (as a user, I would think it<br>
discards changes without saving; but doing so isn't possible with this<br>
dialog type so I'd rather remove the button entirely)<br>
* Detecting when any value is present in any of the fields and<br>
displaying the green checkbox in those cases; if the user removes all<br>
"renamed" fields so nothing is renamed, the checkbox should disappear.<br>
<br>
How does this sound?<br></blockquote><div><br></div><div>Great. Cleared all my doubts. I think might add another "reset" button which will clear visible fields only.<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im HOEnZb"><br>
> 3) I think we should call this "Rename exported database/column/table<br>
> names" -- but I'm open to other suggestions.<br>
><br>
><br>
> This sounds good enough. I will change it soon.<br>
><br>
><br>
> 4) I've tested with many columns and the dialog properly adjusts<br>
> downward, so this is good behavior.<br>
><br>
> I'll make some comments in GitHub as well.<br>
><br>
> Thanks.<br>
><br>
><br>
> > --<br>
> > Regards,<br>
> > Chirayu Chiripal<br>
> > phpMyAdmin Intern - Google Summer of Code 2014<br>
> > <a href="https://chirayuchiripal.wordpress.com/" target="_blank">https://chirayuchiripal.wordpress.com/</a><br>
></div></blockquote></div></div></div>