<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-10-28 20:58 GMT+01:00 Hugues Peccatte <span dir="ltr"><<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">2014-10-19 21:53 GMT+02:00 Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Le 2014-10-19 15:01, Hugues Peccatte a écrit :<br>
<span>> 2014-10-19 13:21 GMT+02:00 Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
</span>> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>>:<br>
<span>><br>
> Le 2014-10-18 14:48, Hugues Peccatte a écrit :<br>
> > 2014-10-13 12:21 GMT+02:00 Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
</span>> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
<span>> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>>>:<br>
> ><br>
> > 2014-10-12 21:06 GMT+02:00 Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>><br>
</span>> > <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>>>:<br>
<span>> ><br>
> > Le 2014-10-12 12:57, Hugues Peccatte a écrit :<br>
> > > 2014-10-05 20:36 GMT+02:00 Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>><br>
> > > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
</span>> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>>>>:<br>
<span>> > ><br>
> > > 2014-10-04 9:01 GMT+02:00 Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>><br>
> > > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
</span>> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>>>>:<br>
<span>> > ><br>
> > > Le 4 oct. 2014 03:22, "Madhura Jayaratne" <<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a> <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a>><br>
> <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a> <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a>>><br>
> > > <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a><br>
> <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a>><br>
</span>> > <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a> <mailto:<a href="mailto:madhura.cj@gmail.com" target="_blank">madhura.cj@gmail.com</a>>>>> a écrit :<br>
<span>> > ><br>
> > ><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > > On Sat, Oct 4, 2014 at 1:24 AM, Hugues Peccatte<br>
> > > <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>><br>
</span>> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>>>><br>
<div><div>> > > wrote:<br>
> > > >><br>
> > > >> 2014-10-03 12:26 GMT+02:00 Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>><br>
> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>><br>
> > > <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>>>>:<br>
> > > >>><br>
> > > >>> Hi Hugues,<br>
> > > >>> I retested this morning on a laptop, importing a<br>
> > SQL file<br>
> > > containing<br>
> > > >>> 10000 employees from the sample employees<br>
> > database. This is<br>
> > > a small file<br>
> > > >>> (660 KB).<br>
> > > >>><br>
> > > >>> Current master: 3 min 25 sec (and ends with<br>
> > JSON.parse:<br>
> > > unexpected<br>
> > > >>> character)<br>
> > > >>><br>
> > > >>> Current Tithugues/stringFunctions_master: 2<br>
> min 10<br>
> > sec (same<br>
> > > js error)<br>
> > > >>><br>
> > > >>> Current QA_4_2: 0 min 5 sec<br>
> > > >>><br>
> > > >>> There has been improvement, but we cannot<br>
> release<br>
> > 4.3 with<br>
> > > this import<br>
> > > >>> speed.<br>
> > > >>><br>
> > > >>> --<br>
> > > >>> Marc Delisle | phpMyAdmin<br>
> > > >><br>
> > > >><br>
> > > >> Hi,<br>
> > > >><br>
> > > >> I agree… But I'm afraid this is linked to<br>
> > multibytes functions…<br>
> > > >> Maybe we shouldn't use the multibytes functions<br>
> > everywhere…<br>
> > > >><br>
> > > >> I'll still try to improve performances.<br>
> > > >><br>
> > > >> Hugues.<br>
> > > >><br>
> > > ><br>
> > > > Indeed, I also think that we should use mb_*<br>
> > function only<br>
> > > when necessary and choice to use them should be made<br>
> > in case by<br>
> > > case basis.<br>
> > > ><br>
> > > > --<br>
> > > > Thanks and Regards,<br>
> > > ><br>
> > > > Madhura Jayaratne<br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > I didn't push my commits, but that's what I've<br>
> started. I<br>
> > > replaced the mb_* calls by standard calls on<br>
> configuration<br>
> > > variables, reserved words, etc.<br>
> > ><br>
> > > Hugues.<br>
> > ><br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > Out of desperation, I try another algorithm. Instead of<br>
> > buffering<br>
> > > data until SQL delimiter, I'll try to parse all lines.<br>
> > > So, I won't parse 1000 times a buffer of 50000<br>
> characters,<br>
> > but less<br>
> > > than 10 times many buffers of 500 characters. I hope<br>
> this<br>
> > will be<br>
> > > faster.<br>
> > ><br>
> > > Hugues.<br>
> > ><br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > The new algorithm is over. There are still some controls to<br>
> > add, but it<br>
> > > is usable with the file in this ticket: [1]<br>
> > > You can find my modifications here: [2]<br>
> > ><br>
> > > Marc, is it faster for you ?<br>
> > > It seems that I won ~33% of time. We're still far from 5<br>
> seconds…<br>
> > > Maybe I'll try to use standard PHP functions to see the<br>
> > difference. If<br>
> > > the standard PHP functions are really faster, I'll try<br>
> to add<br>
> > an option<br>
> > > to use mb_* functions or standard PHP functions, as you<br>
> said.<br>
> > ><br>
> > > [1] <a href="https://sourceforge.net/p/phpmyadmin/bugs/4536/" target="_blank">https://sourceforge.net/p/phpmyadmin/bugs/4536/</a><br>
> > > [2]<br>
> > ><br>
> ><br>
> <a href="https://github.com/Tithugues/phpmyadmin/tree/stringFunctions_useStandardFunctions_master" target="_blank">https://github.com/Tithugues/phpmyadmin/tree/stringFunctions_useStandardFunctions_master</a><br>
> ><br>
> > Hi Hugues,<br>
> > yes it's faster. With the same testing conditions, the import<br>
> > takes 1<br>
> > min 20 sec.<br>
> ><br>
> ><br>
> > --<br>
> > Marc Delisle | phpMyAdmin<br>
> ><br>
> ><br>
> > Thanks for your feedback.<br>
> > I'll try another another improvement to be faster.<br>
> ><br>
> > Note for my self:<br>
> > * read X characters but don't restart the search from 0 each time<br>
> > * search for the escaped quote with a lookbehind expression,<br>
> > something like `(?!<\\)(\\\\)*'`<br>
> ><br>
> > Hugues.<br>
> ><br>
> ><br>
> > Hi,<br>
> ><br>
> > As asked by Marc, I added on option to import by reading as a<br>
> multibytes<br>
> > string or not.<br>
> > The default configuration won't read as multibytes string (because<br>
> it's<br>
> > too long…). It seems that the DnD to import doesn't use the default<br>
> > configuration, so what ever you define as default, it won't be use in<br>
> > this process.<br>
> > Should we create a ticket for this ? I think it's possible to get<br>
> it in<br>
> > javascript.<br>
> ><br>
> > Hugues.<br>
> ><br>
><br>
> With the new option "Read as multibytes" left to its default disabled<br>
> value, my test file imports in 5 seconds.<br>
><br>
> When this option is ticked, it takes 60 seconds.<br>
><br>
> Note that in both cases, I get a Javascript error at the end (the error<br>
> report does not show the same error in Firefox than in Chromium). Can<br>
> anyone confirm this?<br>
><br>
><br>
> --<br>
> Marc Delisle | phpMyAdmin<br>
><br>
><br>
> Marc,<br>
><br>
> Could we please have both errors? I don't have it on Chrome. I'll try on<br>
> Firefox and IE.<br>
><br>
> Thanks,<br>
> Hugues.<br>
<br>
</div></div>>From Iceweasel 24.8.1:<br>
<br>
{<br>
"pma_version": "4.3.0-dev",<br>
"browser_name": "FIREFOX",<br>
"browser_version": "24.0",<br>
"user_os": "Linux",<br>
"server_software": "Apache/2.2.22 (Debian)",<br>
"user_agent_string": "Mozilla/5.0 (X11; Linux x86_64; rv:24.0)<br>
Gecko/20140924 Firefox/24.0 Iceweasel/24.8.1",<br>
"locale": "en",<br>
"configuration_storage": "enabled",<br>
"php_version": "5.4.4-14+deb7u14",<br>
"exception_type": "js",<br>
"exception": {<br>
"mode": "stack",<br>
"name": "SyntaxError",<br>
"message": "JSON.parse: unexpected character",<br>
"stack": [<br>
{<br>
"func": ".parseJSON",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": "PMA_console.initialize/<",<br>
"args": "",<br>
"line": 164,<br>
"column": "",<br>
"context": [<br>
" $('#pma_console_options<br>
input[name=current_query]').prop('c//...",<br>
" PMA_console.updateConfig();",<br>
" });",<br>
"",<br>
" $(document).ajaxComplete(function<br>
(event, xhr) {",<br>
" var data =<br>
$.parseJSON(xhr.responseText);",<br>
" PMA_console.ajaxCallback(data);",<br>
" });",<br>
"",<br>
" PMA_console.isInitialized = true;",<br>
" }"<br>
],<br>
"filename": "console.js"<br>
},<br>
{<br>
"func": "ErrorReport.wrap_function/new_func",<br>
"args": "",<br>
"line": 262,<br>
"column": "",<br>
"context": [<br>
" */",<br>
" wrap_function: function (func) {",<br>
" if (!func.wrapped) {",<br>
" var new_func = function () {",<br>
" try {",<br>
" return func.apply(this,<br>
arguments);",<br>
" } catch (x) {",<br>
" TraceKit.report(x);",<br>
" }",<br>
" };",<br>
" new_func.wrapped = true;"<br>
],<br>
"filename": "error_report.js"<br>
},<br>
{<br>
"func": "v.event.dispatch",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": "$event.dispatch",<br>
"args": "",<br>
"line": 372,<br>
"column": "",<br>
"context": [<br>
"$event.dispatch = function( event ){",<br>
"\tif ( $.data( this, \"suppress.\"+ event.type ) -<br>
new Date().getTime() > 0 ){",<br>
"\t\t$.removeData( this, \"suppress.\"+ event.type );",<br>
"\t\treturn;",<br>
"\t}",<br>
"\treturn $dispatch.apply( this, arguments );",<br>
"};",<br>
"",<br>
"// event fix hooks for touch events...",<br>
"var touchHooks = ",<br>
"$event.fixHooks.touchstart = "<br>
],<br>
"filename": "jquery/jquery.event.drag-2.2.js"<br>
},<br>
{<br>
"func": "v.event.add/u",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": "v.event.trigger",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": "v.event.trigger",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": "T",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
},<br>
{<br>
"func": ".send/r",<br>
"args": "",<br>
"line": 2,<br>
"column": "",<br>
"context": [<br>
"/*! jQuery v1.8.3 <a href="http://jquery.com" target="_blank">jquery.com</a> | <a href="http://jquery.org/license" target="_blank">jquery.org/license</a><br>
*/\r",<br>
"(function(e,t){function _(e){var t=M[e]={};return<br>
v.each(e.split(y),functio//...",<br>
"",<br>
"function sprintf() {",<br>
"/*",<br>
" * Copyright (c) 2013 Kevin van Zonneveld<br>
(<a href="http://kvz.io" target="_blank">http://kvz.io</a>)",<br>
" * and Contributors (<a href="http://phpjs.org/authors" target="_blank">http://phpjs.org/authors</a>)"<br>
],<br>
"filename": "jquery/jquery-1.8.3.min.js"<br>
}<br>
],<br>
"useragent": "Mozilla/5.0 (X11; Linux x86_64; rv:24.0)<br>
Gecko/20140924 Firefox/24.0 Iceweasel/24.8.1",<br>
"incomplete": "false",<br>
"uri": "db_import.php?target="<br>
},<br>
"script_name": "db_import.php",<br>
"microhistory": {<br>
"pages": [<br>
{<br>
"hash":<br>
"index.php?db=&table=&server=1&target=&token=c455fd8a0595a5032d18c07a64e7ab0a"<br>
},<br>
{<br>
"hash":<br>
"db_structure.php?db=test&table=&server=1&target=&token=c455fd8a0595a5032d18c07a64e7ab0a",<br>
"params": {<br>
"opendb_url": "db_structure.php",<br>
"safari_browser": "0",<br>
"collation_connection": "utf8mb4_general_ci",<br>
"lang": "en",<br>
"server": "1",<br>
"text_dir": "ltr",<br>
"pma_text_default_tab": "Browse",<br>
"pma_text_left_default_tab": "Structure",<br>
"LimitChars": "50",<br>
"pftext": "",<br>
"confirm": "true",<br>
"LoginCookieValidity": "144000",<br>
"logged_in": "true"<br>
}<br>
},<br>
{<br>
"hash":<br>
"index.php?db=&table=&server=1&target=&token=c455fd8a0595a5032d18c07a64e7ab0a",<br>
"params": {<br>
"opendb_url": "db_structure.php",<br>
"safari_browser": "0",<br>
"collation_connection": "utf8mb4_general_ci",<br>
"lang": "en",<br>
"server": "1",<br>
"text_dir": "ltr",<br>
"pma_text_default_tab": "Browse",<br>
"pma_text_left_default_tab": "Structure",<br>
"LimitChars": "50",<br>
"pftext": "",<br>
"confirm": "true",<br>
"LoginCookieValidity": "144000",<br>
"logged_in": "true"<br>
}<br>
},<br>
{<br>
"hash":<br>
"db_structure.php?db=test&table=&server=1&target=&token=c455fd8a0595a5032d18c07a64e7ab0a",<br>
"params": {<br>
"opendb_url": "db_structure.php",<br>
"safari_browser": "0",<br>
"collation_connection": "utf8mb4_general_ci",<br>
"lang": "en",<br>
"server": "1",<br>
"text_dir": "ltr",<br>
"pma_text_default_tab": "Browse",<br>
"pma_text_left_default_tab": "Structure",<br>
"LimitChars": "50",<br>
"pftext": "",<br>
"confirm": "true",<br>
"LoginCookieValidity": "144000",<br>
"logged_in": "true"<br>
}<br>
},<br>
{<br>
"hash":<br>
"db_import.php?db=test&table=&server=1&target=&token=c455fd8a0595a5032d18c07a64e7ab0a",<br>
"params": {<br>
"opendb_url": "db_structure.php",<br>
"safari_browser": "0",<br>
"collation_connection": "utf8mb4_general_ci",<br>
"lang": "en",<br>
"server": "1",<br>
"text_dir": "ltr",<br>
"pma_text_default_tab": "Browse",<br>
"pma_text_left_default_tab": "Structure",<br>
"LimitChars": "50",<br>
"pftext": "",<br>
"confirm": "true",<br>
"LoginCookieValidity": "144000",<br>
"logged_in": "true"<br>
}<br>
}<br>
],<br>
"current_index": "5"<br>
<div><div> }<br>
}<br>
<br>
--<br>
Marc Delisle | phpMyAdmin</div></div></blockquote><div><br></div></div></div><div>Hi,</div><div><br></div><div>It seems that the new algorithm is over, see [1]. The unit tests are now ok (except for the one failing on master). I did some tests with escaped quotes (with quote or backslash), delimiters into strings, modified delimiters.</div><div>Marc, do you still have your error please? (I didn't work on it, but I hope that your issue is linked to the not-finished version…)</div><div><br></div><div>Feel free to look at the new algorithm and to tell me if you see any flaw.</div><div>If you can lead to an error with a correct SQL file, please send it to me.</div><div><br></div><div>Thanks for your feedback.</div><div><br></div><div>[1] <a href="https://github.com/Tithugues/phpmyadmin/tree/stringFunctions_useStandardFunctions_master" target="_blank">https://github.com/Tithugues/phpmyadmin/tree/stringFunctions_useStandardFunctions_master</a></div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Hugues.</div></font></span></div></div></div>
</blockquote></div><br></div><div class="gmail_extra">Hi,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Since my previous email, I did some modifications to manage the display of queries in a different way (closer to the current display).</div><div class="gmail_extra"><br></div><div class="gmail_extra">But there is something strange with the attachment… I can import the file (without error and all content executed), but on master, if I paste the content of the file into the SQL console, I've an error… Is it the expected behavior please? I don't see any exotic content in this file…</div><div class="gmail_extra">On my branch, I don't have an error, but only the first statement (DROP PROCEDURE IF EXISTS) is executed…</div><div class="gmail_extra"><br></div><div class="gmail_extra">Thanks,</div><div class="gmail_extra">Hugues.</div></div>