<div dir="ltr">Hi Issac<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
On 3/18/15 9:58 AM, Isaac Bennetch wrote:<br>
> Hi Madhura,<br>
><br>
> On 3/18/15 6:26 AM, Madhura Jayaratne wrote:<br>
>><br>
>><br>
>> On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <<a href="mailto:madhura.cj@gmail.com">madhura.cj@gmail.com</a><br>
>> <mailto:<a href="mailto:madhura.cj@gmail.com">madhura.cj@gmail.com</a>>> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> As per the discussion on the recent team meeting [1] I have started<br>
>> working on updating metro theme to be compatible with phpMyAdmin 4.4<br>
>> and you can find what I've done so far at [2]. I am basically going<br>
>> through all the commits that had some style/image change since 2013<br>
>> and adapting them to metro them to make sure nothing is missed.<br>
>><br>
>> [1] <a href="https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes" target="_blank">https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes</a><br>
>> [2] <a href="https://github.com/madhuracj/metro/commits/master" target="_blank">https://github.com/madhuracj/metro/commits/master</a><br>
>><br>
>> --<br>
>> Thanks and Regards,<br>
>><br>
>> Madhura Jayaratne<br>
>><br>
>><br>
>> Hi devs,<br>
>><br>
>> I think the theme is in a reasonable state now. Would appreciate if you<br>
>> could get the theme from [1] and try it with phpMyAdmin version 4.4 (in<br>
>> Beta) and give feedback.<br>
>><br>
>> [1] <a href="https://github.com/madhuracj/metro/" target="_blank">https://github.com/madhuracj/metro/</a><br>
><br>
> Great progress! Very nice job. I have some thoughts:<br>
><br>
> * On the login page, there's a large 'a' displayed. I don't remember<br>
> much about the metro theme from times past, so maybe the original<br>
> designer had some motivation for it, but I'd rather see a p or our logo<br>
> or something there.<br></div></div></blockquote><div>Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> * On the main page, I see something extra after the Theme selection<br>
> dropdown: "Scheme: win" do you have thoughts about that? I do not see it<br>
> with pmahomme<br>
><br>
> * From a table structure page, under the list of columns there's the<br>
> list of actions; Print view, Propose table structure, etc. The spacing<br>
> between the first three (Print view, Propose table structure, and Track<br>
> table) look okay, but then the rest seem to be squished closer together.<br>
> This is particularly noticeable because the 'e' from "Track table" seems<br>
> to be slightly covered by the icon for "Move columns"<br>
><br>
> * The green color used, for instance, when showing a successful query<br>
> "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit<br>
> bright for the tone of the rest of the theme. It's currently #01A31C,<br>
> perhaps something like #77BB77 would fit better.<br>
><br>
> * The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL<br>
> documentation, and Reload navigation frame -- none of the icons are<br>
> appearing for me. For Home I see an exclamation point, and the rest of<br>
> them have the appearance of unsupported unicode characters. Is this a<br>
> problem with my Firefox?<br></div></div></blockquote><div>No such issues on my Chrome. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> Again, great work.<br>
> ~isaac<br>
><br>
<br>
</div></div>Also, for some reason I don't see a tool tip for the MySQL documentation<br>
when I hover over that icon, but I do see it with the other two themes.<br></blockquote><div>Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code? </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
------------------------------------------------------------------------------<br>
Dive into the World of Parallel Programming The Go Parallel Website, sponsored<br>
by Intel and developed in partnership with Slashdot Media, is your hub for all<br>
things parallel software development, from weekly thought leadership blogs to<br>
news, videos, case studies, tutorials and more. Take a look and join the<br>
conversation now. <a href="http://goparallel.sourceforge.net/" target="_blank">http://goparallel.sourceforge.net/</a><br>
_______________________________________________<br>
Phpmyadmin-devel mailing list<br>
<a href="mailto:Phpmyadmin-devel@lists.sourceforge.net">Phpmyadmin-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>With best regards,</div><div>Kushagra Pandey,</div><div>B.Tech. Part-IV,</div><div>Electrical Engineering,</div><div>IIT (BHU), Varanasi.</div><div><br></div><div>M: +91-9616079370</div><div>Email: <a href="mailto:kushagra4296@gmail.com" style="color:rgb(17,85,204)" target="_blank">kushagra4296@gmail.com</a> </div><div> <a href="mailto:kushagra.pandey.eee11@iitbhu.ac.in" style="color:rgb(17,85,204)" target="_blank">kushagra.pandey.eee11@iitbhu.ac.in</a></div></div></div>
</div></div>