<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 18, 2015 at 9:11 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>Le 2015-08-18 12:31, Hugues Peccatte a écrit :<br>
> Le lun. 17 août 2015 à 22:54, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
</span>> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>> a écrit :<br>
<span>><br>
>     Hi,<br>
>     does anyone remember why the import chunk size is 200?<br>
><br>
</span>>     See https <<a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/issues/11386</a>>://<br>
<span>><br>
><br>
> Hi,<br>
><br>
> I saw this when I rewrote this part, but I've no idea about the reason<br>
> to read only 200 characters...<br>
> I think that we can increase this value.<br>
><br>
> H.<br>
<br>
</span>Hi Hugues,<br>
looking at your comment in<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf</a><br>
<br>
you wanted to reduce the size of data to read, maybe to improve parsing<br>
speed?<br>
<div><div><br>
--<br>
Marc Delisle | phpMyAdmin<br>
<br>
_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra">I asked myself this too, but then I saw this commit [1] and I decided to leave it this way. I believe that there is no performance loss or gain if the size will be increased, because the parser continues from where it left. There is a special case involving DELIMITER statements which may cause a small rewind, but it's negligible. At least, this is what the new parser does, I believe the old one did the same.</div><div class="gmail_extra"><br></div><div class="gmail_extra">[1] <a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c" target="_blank">https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c</a></div><div class="gmail_extra"><br></div><div class="gmail_extra">Best regards,</div><div class="gmail_extra">Dan Ungureanu</div></div>