<p dir="ltr">Le mar. 18 août 2015 à 21:33, Dan Ungureanu <<a href="mailto:udan1107@gmail.com">udan1107@gmail.com</a>> a écrit :</p>
<blockquote><p dir="ltr">On Tue, Aug 18, 2015 at 9:11 PM, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> wrote:</p>
</blockquote>
<blockquote><blockquote><p dir="ltr">Le 2015-08-18 12:31, Hugues Peccatte a écrit :<br>
> Le lun. 17 août 2015 à 22:54, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a><br>
> <mailto:<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>>> a écrit :<br>
><br>
>     Hi,<br>
>     does anyone remember why the import chunk size is 200?<br>
><br>
>     See https <<a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">https</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">://</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">github.com</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/issues/11386">/issues/11386</a>>://<br>
><br>
><br>
> Hi,<br>
><br>
> I saw this when I rewrote this part, but I've no idea about the reason<br>
> to read only 200 characters...<br>
> I think that we can increase this value.<br>
><br>
> H.</p>
<p dir="ltr">Hi Hugues,<br>
looking at your comment in<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">https</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">://</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">github.com</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4caf">/commit/2da2c4caf</a></p>
<p dir="ltr">you wanted to reduce the size of data to read, maybe to improve parsing<br>
speed?<br></p>
<p dir="ltr">--<br>
Marc Delisle | phpMyAdmin</p>
<p dir="ltr">_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">https</a><a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">://</a><a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">lists.phpmyadmin.net</a><a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">/mailman/</a><a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">listinfo</a><a href="https://lists.phpmyadmin.net/mailman/listinfo/developers">/developers</a><br>
</p>
</blockquote>
</blockquote>
<blockquote><p dir="ltr"></p>
<p dir="ltr">I asked myself this too, but then I saw this commit [1] and I decided to leave it this way. I believe that there is no performance loss or gain if the size will be increased, because the parser continues from where it left. There is a special case involving DELIMITER statements which may cause a small rewind, but it's negligible. At least, this is what the new parser does, I believe the old one did the same.<br></p>
<p dir="ltr">[1] <a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">https</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">://</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">github.com</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">/</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">phpmyadmin</a><a href="https://github.com/phpmyadmin/phpmyadmin/commit/2da2c4c">/commit/2da2c4c</a><br></p>
<p dir="ltr">Best regards,</p>
<p dir="ltr">Dan Ungureanu</p>
</blockquote>
<blockquote><p dir="ltr"><br>
</p>
</blockquote>
<p dir="ltr"><br>
</p>
<p dir="ltr">Oops... So I would be the owner of this change...<br>
I believe it was because of the multibytes conversion functions that were too long on "big" string. So I preferred to work on small string, but there are side effects...</p>
<p dir="ltr">We should check the log history, but if the string functions had been rewritten after this, we can think about removing this length limitation.</p>
<p dir="ltr">H.</p>