<div dir="ltr"><div class="gmail_quote"><div dir="ltr">Le jeu. 27 août 2015 à 07:10, Michal Čihař <<a href="mailto:michal@cihar.com">michal@cihar.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dne Wed, 26 Aug 2015 20:05:58 +0000<br>
Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>> napsal(a):<br>
<br>
> Le mer. 26 août 2015 à 14:10, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>> a écrit :<br>
><br>
> > Le 2015-08-26 05:34, Hugues Peccatte a écrit :<br>
> > > Le mar. 25 août 2015 à 15:40, Hugues Peccatte <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
> > > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>> a écrit :<br>
> > ><br>
> > > Le mar. 25 août 2015 à 12:06, Atul Pratap Singh<br>
> > > <<a href="mailto:atulpratapsingh05@gmail.com" target="_blank">atulpratapsingh05@gmail.com</a> <mailto:<a href="mailto:atulpratapsingh05@gmail.com" target="_blank">atulpratapsingh05@gmail.com</a>>> a<br>
> > > écrit :<br>
> > ><br>
> > > On Mon, Aug 24, 2015 at 12:28 AM, Hugues Peccatte<br>
> > > <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>><br>
> > > wrote:<br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > phpMyAdmin's ruleset is based on PEAR standards. One of this<br>
> > > standard<br>
> > > (PEAR_Sniffs_NamingConventions_ValidVariableNameSniff) is to<br>
> > > name class' attributes / methods with a leading underscore<br>
> > > when the element is protected / private.<br>
> > > This rule is quite useful because it helps to see very<br>
> > > quickly if an element is public or not.<br>
> > > But <a href="http://www.php-fig.org/psr/psr-2/#4-2-properties" rel="noreferrer" target="_blank">http://www.php-fig.org/psr/psr-2/#4-2-properties</a> asks<br>
> > > not to use this leading underscore.<br>
> > > For attributes, I'm not sure this is a big deal because<br>
> > > almost all the attributes shouldn't be visible and<br>
> > > accessible only by getters / setters. But for methods, there<br>
> > > is nothing to know the visibility of a method. However<br>
> > > actual IDE help to see this.<br>
> > ><br>
> > > Do you think that we should follow PSR2? Only for attributes<br>
> > > maybe?<br>
> > > Should we consider to base our ruleset on another standard<br>
> > > closest to PSR rules?<br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > I agree to follow PSR-2 no underscore recommendation for<br>
> > > attributes and going forward we may lean more towards PSR,<br>
> > > specifically about achieving codebase wide autoloading of<br>
> > > classes(PSR-4).<br>
> > ><br>
> > > Also, I<br>
> > > think <a href="https://github.com/phpmyadmin/phpmyadmin/pull/11365" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/11365</a> needs<br>
> > > to be rebased.<br>
> > ><br>
> > ><br>
> > > --<br>
> > > Regards<br>
> > ><br>
> > > Atul Pratap Singh<br>
> > ><br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > I won't rebase the branch but remove it.<br>
> > > I'll see the modifications I can do to stick to PSR 0 to 2 rules.<br>
> > ><br>
> > > H.<br>
> > ><br>
> > ><br>
> > > Hi,<br>
> > ><br>
> > > Some days ago, we spoke about this code in all files:<br>
> > > if (! defined('PHPMYADMIN')) {<br>
> > > exit;<br>
> > > }<br>
> > ><br>
> > > In PSR, one of the rules is the "side effects" [0]. This rule says not<br>
> > > to have class/functions/etc declaration and execution in the same file.<br>
> > > And the code above is considered as execution. So here I don't want to<br>
> > > restart the discussion, but we may have to change this if we really want<br>
> > > to stick (not sure about this english word…) to PSR rules.<br>
> > ><br>
> > > H.<br>
> > ><br>
> > > [0] <a href="http://www.php-fig.org/psr/psr-1/#2-3-side-effects" rel="noreferrer" target="_blank">http://www.php-fig.org/psr/psr-1/#2-3-side-effects</a><br>
> ><br>
> > This constant verification can safely be removed if there is no other<br>
> > "execution" code in the file.<br>
> ><br>
> ><br>
> > --<br>
> > Marc Delisle | phpMyAdmin<br>
> ><br>
><br>
> Hi,<br>
><br>
> Has anyone an idea about the origin of this error please?<br>
> <a href="https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/77383289" rel="noreferrer" target="_blank">https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/77383289</a><br>
> I don't see anything special in my modifications that can lead to this<br>
> error…<br>
<br>
Looks like problem with compiling runkit extension... I've changed the<br>
code to stick with particular runkit revision which compiles fine.<br>
<br>
--<br>
Michal Čihař | <a href="http://cihar.com" rel="noreferrer" target="_blank">http://cihar.com</a> | <a href="http://phpmyadmin.net" rel="noreferrer" target="_blank">http://phpmyadmin.net</a></blockquote><div><br></div><div>Thanks a not Michal, It seems to work now!</div><div><br></div><div>H. </div></div></div>