From DelislMa@CollegeSherbrooke.qc.ca Sun May 25 11:03:55 2003
From: Marc Delisle <DelislMa@CollegeSherbrooke.qc.ca>
To: developers@phpmyadmin.net
Subject: Re: [Phpmyadmin-devel] Re: [Phpmyadmin-cvs] CVS: phpMyAdmin
 left.php3,1.125,1.126
Date: Sun, 25 May 2003 11:04:02 +0000
Message-ID: <3ED1067E.9090203@CollegeSherbrooke.qc.ca>
In-Reply-To: <1262.192.168.0.1.1053883823.squirrel@mostlyharmless>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2559076860948761515=="

--===============2559076860948761515==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Garvin,

Ok let's wait until tomorrow for a -rc1. I made my change quickly,
because with your change, clicking on Databases in the left frame
did nothing.

I don't have much time today to think/test, so this will have to wait
until tomorrow.

Marc

Garvin Hicking a =C3=A9crit:
> Hi again.
>=20
> Now I remember - I changed the line in the <noscript> area to left.php3 wit=
hout
> thinking further.
>=20
> The logic is this:
> If JavaScript is enabled, submit the new DB only to the left frame, and let=
 the left
> frame refresh the right frame via JavaScript (this worked for me)
> If no JavaScript is available, post the form to the whole frameset and rebu=
ild it.
> Because a JavaScript Queryframe is not available, we can rebuild the whole =
hash
> without problems. And so the left and main frame should show the new variab=
les.
>=20
> The problem of bug #742632 is not the <form> tag itself, it was right befor=
e I
> changed the line on friday and should be reversed to that state. But the ab=
ove logic
> only applies when a DB is selected - the User reported he clicked the "(Dat=
abases)"
> entry in the dropdown, but the right frame only gets updated when a DB is c=
hosen.
>=20
> So the fix we have to apply is to check if a form submit has been done with=
 an empty
> lightm_db value and change it to the appropriate info.
>=20
> I'm sorry, I have no time to do that until tomorrow evening - if you're wil=
ling to
> put some work into it, please do. In either case, we have to fix that before
> relasing a new RC1 :)
>=20
> Regards,
> Garvin.
> Hi Marc!
>=20
> Why have you changed the script below? We can't submit to the index.php3 an=
d target
> _parent because then the frameset+hash is changed, and any open query windo=
w will
> not target to the main window any more. I'm just remembering that I changed=
 that on
> purpose, but I have no time left today to think into this.
>=20
> We should consider this before releasing 2.5.1 however, so if you've looked=
 into
> this maybe you currently have a more clearer view on this and can tell me, =
why the
> change was needed...
>=20
> Regards,
> Garvin.
>=20
>=20
>>*** left.php3	24 May 2003 11:33:21 -0000	1.125
>>--- left.php3	25 May 2003 11:04:21 -0000	1.126
>>***************
>>*** 360,367 ****
>>          ?>
>>          <script type=3D"text/javascript" language=3D"javascript">
>>!             document.writeln('<form method=3D"post" action=3D"left.php3" =
name=3D"left"
>=20
> target=3D"nav">');
>=20
>>          </script>
>>          <noscript>
>>!             <form method=3D"post" action=3D"left.php3" name=3D"left" targ=
et=3D"nav">
>>          </noscript>
>>          <?php
>>--- 360,367 ----
>>          ?>
>>          <script type=3D"text/javascript" language=3D"javascript">
>>!             document.writeln('<form method=3D"post" action=3D"index.php3"
>=20
> name=3D"left" target=3D"_parent">');
>=20
>>          </script>
>>          <noscript>
>>!             <form method=3D"post" action=3D"index.php3" name=3D"left" tar=
get=3D"_parent">
>>          </noscript>
>>          <?php





--===============2559076860948761515==--