From piotr.prz@gmail.com Thu Jul 14 13:24:17 2011
From: Piotr Przybylski <piotr.prz@gmail.com>
To: developers@phpmyadmin.net
Subject: Re: [Phpmyadmin-devel] XML export
Date: Thu, 14 Jul 2011 15:24:09 +0200
Message-ID:
 <CA+VATszJ6abwJm+YAfHP_tqZnx5r1ch=6cUMtiBM5Oj5J3Fh0Q@mail.gmail.com>
In-Reply-To: <4E1EE654.2000208@infomarc.info>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6990185769228218775=="

--===============6990185769228218775==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

2011/7/14 Marc Delisle <marc(a)infomarc.info>:
> Le 2011-07-13 18:28, Piotr Przybylski a écrit :
>> Hi,
>>
>> Is XML export used at all? It was missing data escaping in many
>> places, and structure (table, function, ...) export was just broken. I
>> fixed it a bit, but there are still some problems that remain:
>> - escaping of table/db names and data in other encodings than ISO-8859-1
>> - it uses SHOW CREATE TABLE without any required fixes
>>
>> File format itself is interesting. I don't expect XML Schema for it to
>> exist, but at least namespace usage should be consistent.
>>
>> I think fixing this and rewriting output format to be more consistent
>> should appear on Tasks for junior developers. And maybe extending it
>> to output data in more concise format, eg.:
>> <table name="">
>> <row>
>> <column_name>value</column_name>
>> ...
>> </row>
>> ...
>> </table>
>>
> Piotr,
> XML export is probably used, how can we know?

Maybe nobody needs DDL in it or we have too few people using it to
report bugs :)

> In your testing, was it just a problem in master or also in 3.4.x?
>

Also in 3.4.x (STABLE). Go to database `evil'"*/>` and try to export
table `evil'"*/>` with all options selected. You will get only data
(no structure) and invalid XML

Another broken plugin is CodeGen, it ignores it's format setting and
always outputs C# code (I will push a bugfix to master later today).

-- 
Piotr Przybylski


--===============6990185769228218775==--