From squirrel@supergarv.de Sun May 25 10:30:49 2003
From: Garvin Hicking <squirrel@supergarv.de>
To: developers@phpmyadmin.net
Subject:
 [Phpmyadmin-devel] Re: [Phpmyadmin-cvs] CVS: phpMyAdmin left.php3,1.125,1.126
Date: Sun, 25 May 2003 10:31:03 +0000
Message-ID: <1262.192.168.0.1.1053883823.squirrel@mostlyharmless>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3525525138978277170=="

--===============3525525138978277170==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi again.

Now I remember - I changed the line in the <noscript> area to left.php3 witho=
ut
thinking further.

The logic is this:
If JavaScript is enabled, submit the new DB only to the left frame, and let t=
he left
frame refresh the right frame via JavaScript (this worked for me)
If no JavaScript is available, post the form to the whole frameset and rebuil=
d it.
Because a JavaScript Queryframe is not available, we can rebuild the whole ha=
sh
without problems. And so the left and main frame should show the new variable=
s.

The problem of bug #742632 is not the <form> tag itself, it was right before I
changed the line on friday and should be reversed to that state. But the abov=
e logic
only applies when a DB is selected - the User reported he clicked the "(Datab=
ases)"
entry in the dropdown, but the right frame only gets updated when a DB is cho=
sen.

So the fix we have to apply is to check if a form submit has been done with a=
n empty
lightm_db value and change it to the appropriate info.

I'm sorry, I have no time to do that until tomorrow evening - if you're willi=
ng to
put some work into it, please do. In either case, we have to fix that before
relasing a new RC1 :)

Regards,
Garvin.
Hi Marc!

Why have you changed the script below? We can't submit to the index.php3 and =
target
_parent because then the frameset+hash is changed, and any open query window =
will
not target to the main window any more. I'm just remembering that I changed t=
hat on
purpose, but I have no time left today to think into this.

We should consider this before releasing 2.5.1 however, so if you've looked i=
nto
this maybe you currently have a more clearer view on this and can tell me, wh=
y the
change was needed...

Regards,
Garvin.

> *** left.php3	24 May 2003 11:33:21 -0000	1.125
> --- left.php3	25 May 2003 11:04:21 -0000	1.126
> ***************
> *** 360,367 ****
>           ?>
>           <script type=3D"text/javascript" language=3D"javascript">
> !             document.writeln('<form method=3D"post" action=3D"left.php3" =
name=3D"left"
target=3D"nav">');
>           </script>
>           <noscript>
> !             <form method=3D"post" action=3D"left.php3" name=3D"left" targ=
et=3D"nav">
>           </noscript>
>           <?php
> --- 360,367 ----
>           ?>
>           <script type=3D"text/javascript" language=3D"javascript">
> !             document.writeln('<form method=3D"post" action=3D"index.php3"
name=3D"left" target=3D"_parent">');
>           </script>
>           <noscript>
> !             <form method=3D"post" action=3D"index.php3" name=3D"left" tar=
get=3D"_parent">
>           </noscript>
>           <?php
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: ObjectStore.
> If flattening out C++ or Java code to make your application fit in a relati=
onal
database is painful, don't do it! Check out ObjectStore. Now part of Progress
Software. http://www.objectstore.net/sourceforge
_______________________________________________
> Phpmyadmin-cvs mailing list
> Phpmyadmin-cvs(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-cvs
>
>
>
>
>


--=20
Bye,
Garvin.



--=20
Bye,
Garvin.


--===============3525525138978277170==--