From marc@infomarc.info Thu Jul 14 13:29:51 2011
From: Marc Delisle <marc@infomarc.info>
To: developers@phpmyadmin.net
Subject: Re: [Phpmyadmin-devel] XML export
Date: Thu, 14 Jul 2011 09:31:09 -0400
Message-ID: <4E1EEF9D.8050207@infomarc.info>
In-Reply-To:
 <CA+VATszJ6abwJm+YAfHP_tqZnx5r1ch=6cUMtiBM5Oj5J3Fh0Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6955477367978873216=="

--===============6955477367978873216==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Le 2011-07-14 09:24, Piotr Przybylski a écrit :
> 2011/7/14 Marc Delisle<marc(a)infomarc.info>:
>> Le 2011-07-13 18:28, Piotr Przybylski a écrit :
>>> Hi,
>>>
>>> Is XML export used at all? It was missing data escaping in many
>>> places, and structure (table, function, ...) export was just broken. I
>>> fixed it a bit, but there are still some problems that remain:
>>> - escaping of table/db names and data in other encodings than ISO-8859-1
>>> - it uses SHOW CREATE TABLE without any required fixes
>>>
>>> File format itself is interesting. I don't expect XML Schema for it to
>>> exist, but at least namespace usage should be consistent.
>>>
>>> I think fixing this and rewriting output format to be more consistent
>>> should appear on Tasks for junior developers. And maybe extending it
>>> to output data in more concise format, eg.:
>>> <table name="">
>>> <row>
>>> <column_name>value</column_name>
>>> ...
>>> </row>
>>> ...
>>> </table>
>>>
>> Piotr,
>> XML export is probably used, how can we know?
>
> Maybe nobody needs DDL in it or we have too few people using it to
> report bugs :)
>
>> In your testing, was it just a problem in master or also in 3.4.x?
>>
>
> Also in 3.4.x (STABLE). Go to database `evil'"*/>` and try to export
> table `evil'"*/>` with all options selected. You will get only data
> (no structure) and invalid XML

Can you backport your fixes to QA_3_4?

>
> Another broken plugin is CodeGen, it ignores it's format setting and
> always outputs C# code (I will push a bugfix to master later today).
>


-- 
Marc Delisle
http://infomarc.info


--===============6955477367978873216==--