On Sun, Jul 28, 2013 at 7:18 PM, Marc Delisle marc@infomarc.info wrote:
Le 2013-07-28 09:22, J. M. a écrit :
Date: Sat, 27 Jul 2013 17:16:33 -0400 From: marc@infomarc.info To: phpmyadmin-devel@lists.sourceforge.net Subject: [Phpmyadmin-devel] about $GLOBALS['PMA_String']
Hi, since the merging of pull request 543, I guess that we should try to port all remaining places that use the native corresponding string functions, to the new syntax?
This way we can benefit, for example, from the multibyte version of these functions.
Who's assigned? :)
Sorry, I was not clear enough. My "guess" was intended as a clarification question, to see whether I understood the goal of this pull request.
Marc,
The pull request was intended at introducing a better class structure for the string handling classes and to make the functions accessible via single $GLOBALS['PMA_String'] object, compared to $GLOBALS['PMA_String'], $GLOBALS['PMA_StringType'] variables and PMA_STR_ prefixed functions, which was the case earlier.
Indeed, by porting remaining places to use $GLOBALS['PMA_String'] we can benefit from the advantages you mentioned.