On 06/16/2013 12:59 PM, Mohamed Ashraf wrote:

On Wed, Jun 12, 2013 at 9:58 AM, Rouslan Placella <rouslan@placella.com> wrote:

Some of my thoughts are:

* Try/catch has a performance penalty

it is not too big as can be seen here

http://jsperf.com/try-catch-performance-overhead

Really? On some browsers it's about 20 times slower on the very

benchmark that you are linking to!

* We need to be able to easily turn off the error reporting feature

You can do it simply by setting a config option I have already set it

up in the Header.class.php

* Some/most function names in the stack trace are going to be useless as

the production js code is minified.

* The line numbers in the file will not be of much help either, I guess,

unless we change the way that the files are minified (like forcing line

breaks every few hundred characters).

since uglified js provides little to no information about the location

of the error. what should we do. I checked up on source maps however

the browser support is not enough. so what do you think should happen.

I think the only way to go is to add try and catch to all the

different functions if you need to find out where the error has

occured. however adding try and catch statements to the entire

codebase will decrease code readability considerably.

------------------------------------------------------------------------------

This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

_______________________________________________

Phpmyadmin-devel mailing list

Phpmyadmin-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel