On Mon, May 21, 2012 at 10:32 PM, Marc Delisle
<marc(a)infomarc.info> wrote:
Le 2012-05-21 12:47, Thilina Buddika Abeyrathna a
écrit :
On Mon, May 21, 2012 at 9:54 PM, Marc Delisle
<marc(a)infomarc.info>
wrote:
> Le 2012-05-21 11:50, Thilina Buddika Abeyrathna a écrit :
>> On Mon, May 21, 2012 at 9:17 PM, Marc Delisle <marc(a)infomarc.info>
> wrote:
>>
>>> Le 2012-05-21 11:41, Thilina Buddika Abeyrathna a écrit :
>>>> Hi Marc,
>>>> In tbl_replace.php I don't see any usage of $me_fields variable. So
I'm
>>>> going to remove the declaration
and I'll change the all variable
names
>>>> $me_* to $multi_edit_*.
>>>> Is it OK?
>>>
>>> Hi Thilina,
>>> If you have access to command-line git, try this:
>>>
>>> git grep '$me_fields'
>>>
>>> and you'll see that libraries/tbl_replace_fields.inc.php is using
these
>>
variables (other scripts are also using them).
>>
>> I just realize that Marc. Sorry for the mistake.
> And is it ok to changing variable name like above.
Yes, this is good refactoring. Of course, you know I'm allergic to using
the term "field" when it refers to a table's column.
Ok Marc. :)
By the way, I prefer that you finish your work on tbl_change before
working on tbl_replace.
I wish to merge your work soon, but there are still things to improve or
fix:
- the multi-row edit bug
- the $vrow and $vresult variables
Hi Marc,
I'm trying to fix the multi-row edit bug. But still I couldn't find the
place which is wrong that I have done when refactoring.