On Mon, May 7, 2012 at 5:34 PM, Marc Delisle <marc@infomarc.info> wrote:

Hi,

We previously had a script called grab_globals.lib.php, which created
global variables from a few superglobals arrays.

When this script was removed a few weeks ago, we added at the beginning
of other scripts some code, for example in tbl_change.php:

if (isset($_REQUEST['where_clause'])) {
   $where_clause = $_REQUEST['where_clause'];
}

In the upcoming refactoring efforts, we should avoid this, because,
looking at the code further in the script, it's difficult to see the
origin of $where_clause. So, we should only refer to
$_REQUEST['where_clause'] (except in the situations where the global is
modified afterwards).

Another benefit is that this variable would not need to be passed as a
parameter to functions.