I had to set pma db var equal to "phpmyadmin" as for some reasons it was not set to "phpmyadmin" by default.

Why do you duplicate lot of information in permUsrPref class (user
name, table name, database link,...)?

Such parameters are set only once in the constructor. Can you please elaborate with a minimal example what do you mean by duplication?

In server_perm_storage.php there is a huge code duplication, please
have just one piece code to handle setting the value and do not copy it
for every available optiofn.

I thought each setting would have different test cases, that's why I set up conditional statements separately. May be I can reduce code by generalizing test cases, but I am not sure if it would be a probable solution. What are your thoughts?

Thanks!

On Wed, Jul 29, 2009 at 4:59 AM, Michal Čihař <michal@cihar.com> wrote:

Hi

Dne Tue, 28 Jul 2009 03:24:25 -0400
"Zeeshan M." <zeeshan.jp@gmail.com> napsal(a):

> I uploaded a revision for patch #

> <goog_1248753684487>2825187<https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file_id=336915&aid=2825187>at
> sourceforge.net.

Why do you introduce syntax errors (calendar.php)?

Why do you change config defaults (libraries/config.default.php)?

Why do you duplicate lot of information in permUsrPref class (user
name, table name, database link,...)?

In server_perm_storage.php there is a huge code duplication, please
have just one piece code to handle setting the value and do not copy it
for every available option.

--
Michal Čihař | http://cihar.com | http://phpmyadmin.cz

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel