On Mon, May 30, 2011 at 6:47 PM, Marc Delisle marc@infomarc.info wrote:
Tyron Madlener a écrit :
Since I always have a love for details, here's 3 small suggestions that maybe can be merged into the master branch. They are all pushed to my fork (http://repo.or.cz/w/phpmyadmin/tyronm.git):
- Commit a0302c666c1bf9f9715364a6301238b474aedac1
Removes timepicker.js. It is already included with the jquery ui. The file was included only in tbl_change.php and tbl_select.php
Tyron, I don't see a timepicker in jQuery UI's Datepicker. It only handles the date, not the time.
Oh right. But it is not being used. tab_change.js uses PMA_addDatepicker() from functions.js which uses $.datepicker(), not $.timepicker() from what I can see.
And tbl_select.js interestingly doesn't initialize any date/timepicker widget at all.
Shall I try and implement it instead?
- Commit b161f43ec9089e0d2d5fb8a619056e6f9577a380
When reloading (flushing) privileges on the privileges tab you get a 5 second long success message. This commit omits the success message and removes the loading message as soon as the ajax request is done. This behavior seems more consistent with my patch in April that removes messages once the ajax request is completed.
Merged, thanks.
- Commit 99775c9bad552aac8b904996d673f1023821ab13
Removes the initials table on the privileges tab if there is 20 or less privileges to show. With 1-20 privileges you can easily see all host names and don't need any filtering by initials imo. I would even increase that limit to 30 or so.
Merged, thanks. P.S. For these commits you have Author: unknown <Tyron@.(none)>
Yea, I've made commits before adding my ssh key on my Laptop. I've fixed it already. But thanks.
-- Marc Delisle http://infomarc.info
vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel