On Thu, Jun 13, 2013 at 12:38 PM, Michal Čihař <michal@cihar.com> wrote:

Hi

Dne Thu, 13 Jun 2013 11:51:18 +0530
Supun Nakandala <supun.nakandala@gmail.com> napsal(a):

> I am refactoring sql.php and I see some places where parsing of the sql
> query done in the sql.php (eg line 445). I am planning to crate new methods
> for these tasks in sqlparser.lib.php and call them from sql.php . I would
> like to know the opinion from the developers about this approach.

Actually it would be better if those regular expressions would use
parser because it would give it more tolerance to comments in SQL.

Hi Michal,

PMA_SQP_parse($sql_query) in sqlparser.lib.php is basically checking the sql query and setting some global variables. Could you please elaborate on how to use that function instead of these regular expressions such that it gives more tolerance to comments in SQL.

Thank you.

--
Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

--
Thank you
Supun Nakandala
Dept. Computer Science and Engineering
University of Moratuwa